<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">David,<div class=""><br class=""></div><div class="">Please commit that patch with a comment about what it is fixing. I suspect we’ll want to fix that in a different way eventually, but it may take some time to work that out and fixing the broken build is important.</div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 2, 2016, at 1:15 PM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" class="">xinliangli@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><br class=""></div>The following patch fixes the problem. With this patch, ninja check-profile reports success with 129 passes. <div class=""><br class=""></div><div class="">Can you check if it is the right fix?</div><div class=""><br class=""></div><div class="">David<br class=""><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class="">Index: CMakeLists.txt</div><div class="">===================================================================</div><div class="">--- CMakeLists.txt (revision 271566)</div><div class="">+++ CMakeLists.txt (working copy)</div><div class="">@@ -16,6 +16,7 @@ else()</div><div class=""> endif()</div><div class=""> </div><div class=""> cmake_minimum_required(VERSION 3.4.3)</div><div class="">+cmake_policy(SET CMP0056 OLD) </div><div class=""> </div><div class=""> # FIXME: It may be removed when we use 2.8.12.</div><div class=""> if(CMAKE_VERSION VERSION_LESS 2.8.12)</div><div class=""><br class=""></div></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></div></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Jun 2, 2016 at 12:00 PM, Xinliang David Li <span dir="ltr" class=""><<a href="mailto:xinliangli@gmail.com" target="_blank" class="">xinliangli@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Chris, this change seems to have broken compiler_rt testing's coverage. WIth this change, PROFILE_SUPPORTED_ARCH is no longer properly defined. On X86_64, it is defined to be X86_64 while before this change, it was set to X86_64, i386 and i686. The errors I got:<div class=""><br class=""></div><div class=""><div class="">cannot open ... ../lib/clang/3.9.0/lib/linux/libclang_rt.profile-i386.a: No such file or directory</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">sanitizer testing seems to be affected too -- no failures, but the number of tests is reduced.</div></div><div class=""><br class=""></div><div class="">Can you take a look?</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">David</div><div class=""><br class=""></div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, May 31, 2016 at 1:21 PM, Chris Bieneman via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br class="">
Date: Tue May 31 15:21:42 2016<br class="">
New Revision: 271327<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271327&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=271327&view=rev</a><br class="">
Log:<br class="">
[CMake] Update to requiring CMake 3.4.3<br class="">
<br class="">
Summary:<br class="">
This is as per the discussions on developer lists:<br class="">
<br class="">
<a href="http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html</a><br class="">
<a href="http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html</a><br class="">
<br class="">
Subscribers: llvm-commits<br class="">
<br class="">
Differential Revision: <a href="http://reviews.llvm.org/D20824" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D20824</a><br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/CMakeLists.txt<br class="">
compiler-rt/trunk/lib/builtins/CMakeLists.txt<br class="">
<br class="">
Modified: compiler-rt/trunk/CMakeLists.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff</a><br class="">
==============================================================================<br class="">
--- compiler-rt/trunk/CMakeLists.txt (original)<br class="">
+++ compiler-rt/trunk/CMakeLists.txt Tue May 31 15:21:42 2016<br class="">
@@ -15,16 +15,7 @@ else()<br class="">
set(COMPILER_RT_STANDALONE_BUILD FALSE)<br class="">
endif()<br class="">
<br class="">
-# The CompilerRT build system requires CMake version 2.8.8 or higher in order<br class="">
-# to use its support for building convenience "libraries" as a collection of<br class="">
-# .o files. This is particularly useful in producing larger, more complex<br class="">
-# runtime libraries.<br class="">
-if (NOT MSVC)<br class="">
- cmake_minimum_required(VERSION 2.8.8)<br class="">
-else()<br class="">
- # Version 2.8.12.1 is required to build with Visual Studio 2013.<br class="">
- cmake_minimum_required(VERSION 2.8.12.1)<br class="">
-endif()<br class="">
+cmake_minimum_required(VERSION 3.4.3)<br class="">
<br class="">
# FIXME: It may be removed when we use 2.8.12.<br class="">
if(CMAKE_VERSION VERSION_LESS 2.8.12)<br class="">
<br class="">
Modified: compiler-rt/trunk/lib/builtins/CMakeLists.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff</a><br class="">
==============================================================================<br class="">
--- compiler-rt/trunk/lib/builtins/CMakeLists.txt (original)<br class="">
+++ compiler-rt/trunk/lib/builtins/CMakeLists.txt Tue May 31 15:21:42 2016<br class="">
@@ -3,7 +3,7 @@<br class="">
# architecture-specific code in various subdirectories.<br class="">
<br class="">
if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)<br class="">
- cmake_minimum_required(VERSION 2.8.12.1)<br class="">
+ cmake_minimum_required(VERSION 3.4.3)<br class="">
<br class="">
project(CompilerRTBuiltins C ASM)<br class="">
set(COMPILER_RT_STANDALONE_BUILD TRUE)<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>