<div dir="ltr">(I see this was reverted - but when it goes back it it could use a test case)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 26, 2016 at 9:28 AM, Xinliang David Li via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davidxl<br>
Date: Thu May 26 11:28:01 2016<br>
New Revision: 270865<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=270865&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=270865&view=rev</a><br>
Log:<br>
Use new interface in Triple /NFC<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp?rev=270865&r1=270864&r2=270865&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp?rev=270865&r1=270864&r2=270865&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp Thu May 26 11:28:01 2016<br>
@@ -790,7 +790,7 @@ static void createIRLevelProfileFlagVari<br>
       INSTR_PROF_QUOTE(IR_LEVEL_PROF_VERSION_VAR));<br>
   IRLevelVersionVariable->setVisibility(GlobalValue::DefaultVisibility);<br>
   Triple TT(M.getTargetTriple());<br>
-  if (TT.isOSBinFormatMachO())<br>
+  if (!TT.supportsCOMDAT())<br>
     IRLevelVersionVariable->setLinkage(GlobalValue::WeakAnyLinkage);<br>
   else<br>
     IRLevelVersionVariable->setComdat(M.getOrInsertComdat(<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>