I don't think raw-all should imply any of the 3 byte dumping options, it will just be too much data. <br><div class="gmail_quote"><div dir="ltr">On Thu, May 26, 2016 at 3:52 PM Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ruiu updated this revision to Diff 58709.<br>
ruiu added a comment.<br>
<br>
- Update tests.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D20707" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20707</a><br>
<br>
Files:<br>
test/DebugInfo/PDB/pdbdump-headers.test<br>
tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
<br>
Index: tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
===================================================================<br>
--- tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
+++ tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
@@ -147,6 +147,10 @@<br>
DumpSymRecordBytes("raw-sym-record-bytes",<br>
cl::desc("dump CodeView symbol record raw bytes"),<br>
cl::cat(NativeOtions));<br>
+cl::opt<bool><br>
+ RawAll("raw-all",<br>
+ cl::desc("Implies all other options in 'Native Options' category"),<br>
+ cl::cat(NativeOtions));<br>
<br>
cl::list<std::string><br>
ExcludeTypes("exclude-types",<br>
@@ -823,6 +827,21 @@<br>
opts::Lines = true;<br>
}<br>
<br>
+ if (opts::RawAll) {<br>
+ opts::DumpHeaders = true;<br>
+ opts::DumpModules = true;<br>
+ opts::DumpModuleFiles = true;<br>
+ opts::DumpModuleSyms = true;<br>
+ opts::DumpPublics = true;<br>
+ opts::DumpStreamSummary = true;<br>
+ opts::DumpStreamBlocks = true;<br>
+ opts::DumpSymRecordBytes = true;<br>
+ opts::DumpTpiRecordBytes = true;<br>
+ opts::DumpTpiRecords = true;<br>
+ opts::DumpIpiRecords = true;<br>
+ opts::DumpIpiRecordBytes = true;<br>
+ }<br>
+<br>
// When adding filters for excluded compilands and types, we need to remember<br>
// that these are regexes. So special characters such as * and \ need to be<br>
// escaped in the regex. In the case of a literal \, this means it needs to<br>
Index: test/DebugInfo/PDB/pdbdump-headers.test<br>
===================================================================<br>
--- test/DebugInfo/PDB/pdbdump-headers.test<br>
+++ test/DebugInfo/PDB/pdbdump-headers.test<br>
@@ -1,6 +1,9 @@<br>
; RUN: llvm-pdbdump -raw-headers -raw-tpi-records -raw-tpi-record-bytes -raw-module-syms \<br>
; RUN: -raw-sym-record-bytes -raw-publics -raw-module-files -raw-stream-name=/names \<br>
-; RUN: -raw-stream-summary -raw-ipi-records -raw-ipi-record-bytes %p/Inputs/empty.pdb \<br>
+; RUN: -raw-stream-summary -raw-stream-blocks -raw-ipi-records -raw-ipi-record-bytes \<br>
+; RUN: %p/Inputs/empty.pdb \<br>
+; RUN: | FileCheck -check-prefix=EMPTY %s<br>
+; RUN: llvm-pdbdump -raw-all -raw-stream-name=/names %p/Inputs/empty.pdb \<br>
; RUN: | FileCheck -check-prefix=EMPTY %s<br>
; RUN: llvm-pdbdump -raw-headers -raw-stream-name=/names -raw-modules -raw-module-files \<br>
; RUN: %p/Inputs/big-read.pdb | FileCheck -check-prefix=BIG %s<br>
@@ -37,6 +40,25 @@<br>
; EMPTY-NEXT: Stream 15: [TPI Hash] (308 bytes)<br>
; EMPTY-NEXT: Stream 16: [IPI Hash] (68 bytes)<br>
; EMPTY-NEXT: ]<br>
+; EMPTY-NEXT: StreamBlocks [<br>
+; EMPTY-NEXT: Stream 0: [8]<br>
+; EMPTY-NEXT: Stream 1: [19]<br>
+; EMPTY-NEXT: Stream 2: [18, 17]<br>
+; EMPTY-NEXT: Stream 3: [14]<br>
+; EMPTY-NEXT: Stream 4: [20]<br>
+; EMPTY-NEXT: Stream 5: []<br>
+; EMPTY-NEXT: Stream 6: [11]<br>
+; EMPTY-NEXT: Stream 7: [13]<br>
+; EMPTY-NEXT: Stream 8: [12]<br>
+; EMPTY-NEXT: Stream 9: []<br>
+; EMPTY-NEXT: Stream 10: [10]<br>
+; EMPTY-NEXT: Stream 11: [15]<br>
+; EMPTY-NEXT: Stream 12: [6]<br>
+; EMPTY-NEXT: Stream 13: [16]<br>
+; EMPTY-NEXT: Stream 14: [7]<br>
+; EMPTY-NEXT: Stream 15: [21]<br>
+; EMPTY-NEXT: Stream 16: [22]<br>
+; EMPTY-NEXT: ]<br>
; EMPTY-NEXT: PDB Stream {<br>
; EMPTY-NEXT: Version: 20000404<br>
; EMPTY-NEXT: Signature: 0x54E507E2<br>
<br>
<br>
</blockquote></div>