<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 24, 2016 at 3:59 PM, Michael Zolotukhin via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: mzolotukhin<br>
Date: Tue May 24 17:59:58 2016<br>
New Revision: 270629<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=270629&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=270629&view=rev</a><br>
Log:<br>
[LoopUnrollAnalyzer] Fix a crash in UnrolledInstAnalyzer::visitCastInst.<br>
<br>
This fixes PR27847. Now for real.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp<br>
    llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll<br>
<br>
Modified: llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp?rev=270629&r1=270628&r2=270629&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp?rev=270629&r1=270628&r2=270629&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/LoopUnrollAnalyzer.cpp Tue May 24 17:59:58 2016<br>
@@ -141,11 +141,7 @@ bool UnrolledInstAnalyzer::visitCastInst<br>
   Constant *COp = dyn_cast<Constant>(I.getOperand(0));<br>
   if (!COp)<br>
     COp = SimplifiedValues.lookup(I.getOperand(0));<br>
-  if (COp) {<br>
-    if (COp->getType() == I.getType()) {<br>
-      SimplifiedValues[&I] = cast<Constant>(COp);<br>
-      return true;<br>
-    }<br>
+  if (COp && CastInst::castIsValid(I.getOpcode(), COp, I.getType())) {<br></blockquote><div><br></div><div>How are you getting into a situation where "V.getType() != SimplifiedValues.lookup(V).getType()"?  It seems like there's an underlying problem which is getting ignored here.<br><br></div><div>-Eli<br></div></div></div></div>