<div dir="ltr">Any particular reason? If it only has public inheritance and public members, struct seems fine.<div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 8:58 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Thu May 19 10:58:02 2016<br>
New Revision: 270074<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=270074&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=270074&view=rev</a><br>
Log:<br>
[SCCP] Prefer class to struct.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h<br>
    llvm/trunk/lib/Transforms/Scalar/SCCP.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h?rev=270074&r1=270073&r2=270074&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h?rev=270074&r1=270073&r2=270074&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h (original)<br>
+++ llvm/trunk/include/llvm/Transforms/Scalar/SCCP.h Thu May 19 10:58:02 2016<br>
@@ -27,7 +27,8 @@<br>
 namespace llvm {<br>
<br>
 /// This pass performs function-level constant propagation and merging.<br>
-struct SCCPPass : PassInfoMixin<SCCPPass> {<br>
+class SCCPPass : public PassInfoMixin<SCCPPass> {<br>
+public:<br>
   PreservedAnalyses run(Function &F, AnalysisManager<Function> &AM);<br>
 };<br>
 }<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/SCCP.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SCCP.cpp?rev=270074&r1=270073&r2=270074&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SCCP.cpp?rev=270074&r1=270073&r2=270074&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/SCCP.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/SCCP.cpp Thu May 19 10:58:02 2016<br>
@@ -1638,7 +1638,8 @@ namespace {<br>
 /// SCCP Class - This class uses the SCCPSolver to implement a per-function<br>
 /// Sparse Conditional Constant Propagator.<br>
 ///<br>
-struct SCCPLegacyPass : public FunctionPass {<br>
+class SCCPLegacyPass : public FunctionPass {<br>
+public:<br>
   void getAnalysisUsage(AnalysisUsage &AU) const override {<br>
     AU.addRequired<TargetLibraryInfoWrapperPass>();<br>
     AU.addPreserved<GlobalsAAWrapperPass>();<br>
@@ -1960,7 +1961,8 @@ namespace {<br>
 /// IPSCCP Class - This class implements interprocedural Sparse Conditional<br>
 /// Constant Propagation.<br>
 ///<br>
-struct IPSCCPLegacyPass : public ModulePass {<br>
+class IPSCCPLegacyPass : public ModulePass {<br>
+public:<br>
   static char ID;<br>
<br>
   IPSCCPLegacyPass() : ModulePass(ID) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>