<div dir="ltr"><div><a href="http://reviews.llvm.org/rL270128" rel="noreferrer" target="_blank">http://reviews.llvm.org/rL270128</a><br><br></div>Sorry about the breakage. I'm on a roll. I swear I didn't write the buggy code this time. :)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 2:59 PM, Mike Aizatsky <span dir="ltr"><<a href="mailto:aizatsky@google.com" target="_blank">aizatsky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Commenting the test would be appreciated to stabilize the build.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Thu, May 19, 2016 at 1:42 PM Sanjay Patel via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi Mike -<br><br></div>Yep, I accidentally uncovered a bug. I've posted a patch for review here:<br><a href="http://reviews.llvm.org/D20434" target="_blank">http://reviews.llvm.org/D20434</a><br><br></div>Would it be better to comment out the offending line of the test until the patch is reviewed?<br><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 19, 2016 at 2:10 PM, Mike Aizatsky <span dir="ltr"><<a href="mailto:aizatsky@google.com" target="_blank">aizatsky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sanjay,<div><br></div><div>I think this breaks sanitizer build:</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/12914" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/12914</a><br></div><div><br></div><div><div>/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:667:26: runtime error: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value to itself</div><div> #0 0x85272a in llvm::MCExpr::evaluateAsRelocatableImpl(llvm::MCValue&, llvm::MCAssembler const*, llvm::MCAsmLayout const*, llvm::MCFixup const*, llvm::DenseMap<llvm::MCSection const*, unsigned long, llvm::DenseMapInfo<llvm::MCSection const*>, llvm::detail::DenseMapPair<llvm::MCSection const*, unsigned long> > const*, bool) const /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:667:26</div><div> #1 0x851e04 in llvm::MCExpr::evaluateAsAbsolute(long&, llvm::MCAssembler const*, llvm::MCAsmLayout const*, llvm::DenseMap<llvm::MCSection const*, unsigned long, llvm::DenseMapInfo<llvm::MCSection const*>, llvm::detail::DenseMapPair<llvm::MCSection const*, unsigned long> > const*, bool) const /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCExpr.cpp:439:7</div><div> #2 0x8b5e5a in (anonymous namespace)::AsmParser::parseExpression(llvm::MCExpr const*&, llvm::SMLoc&) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:1095:7</div><div> #3 0x5d74bd in (anonymous namespace)::X86AsmParser::ParseATTOperand() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1908:9</div><div> #4 0x5d4b54 in (anonymous namespace)::X86AsmParser::ParseOperand() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1137:10</div><div> #5 0x5cd0da in (anonymous namespace)::X86AsmParser::ParseInstruction(llvm::ParseInstructionInfo&, llvm::StringRef, llvm::SMLoc, llvm::SmallVectorImpl<std::unique_ptr<llvm::MCParsedAsmOperand, std::default_delete<llvm::MCParsedAsmOperand> > >&) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2319:44</div><div> #6 0x8ba751 in (anonymous namespace)::AsmParser::parseStatement((anonymous namespace)::ParseStatementInfo&, llvm::MCAsmParserSemaCallback*) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:1771:19</div><div> #7 0x8b2c02 in (anonymous namespace)::AsmParser::Run(bool, bool) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/MC/MCParser/AsmParser.cpp:675:10</div><div> #8 0x43dbdc in AssembleInput(char const*, llvm::Target const*, llvm::SourceMgr&, llvm::MCContext&, llvm::MCStreamer&, llvm::MCAsmInfo&, llvm::MCSubtargetInfo&, llvm::MCInstrInfo&, llvm::MCTargetOptions&) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/llvm-mc/llvm-mc.cpp:352:13</div><div> #9 0x43c595 in main /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/llvm-mc/llvm-mc.cpp:523:11</div><div> #10 0x7fc83364fec4 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21ec4)</div><div> #11 0x41b5fd in _start (/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/bin/llvm-mc+0x41b5fd)</div><div><br></div></div></div><div><div><br><div class="gmail_quote"><div dir="ltr">On Wed, May 18, 2016 at 1:32 PM Sanjay Patel via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Wed May 18 15:26:32 2016<br>
New Revision: 269977<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269977&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=269977&view=rev</a><br>
Log:<br>
[x86] add test for immediate comment formatting<br>
<br>
Added:<br>
llvm/trunk/test/MC/X86/imm-comments.s<br>
<br>
Added: llvm/trunk/test/MC/X86/imm-comments.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/imm-comments.s?rev=269977&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/imm-comments.s?rev=269977&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/X86/imm-comments.s (added)<br>
+++ llvm/trunk/test/MC/X86/imm-comments.s Wed May 18 15:26:32 2016<br>
@@ -0,0 +1,26 @@<br>
+# RUN: llvm-mc %s -triple=x86_64-unknown-unknown | FileCheck %s<br>
+<br>
+movb $127, %al<br>
+movb $-128, %al<br>
+<br>
+movw $32767, %ax<br>
+movw $-32768, %ax<br>
+<br>
+movl $2147483647, %eax<br>
+movl $-<a href="tel:2147483648" value="+12147483648" target="_blank">2147483648</a>, %eax<br>
+<br>
+movabsq $9223372036854775807, %rax<br>
+movabsq $-9223372036854775808, %rax<br>
+<br>
+# CHECK: movb $127, %al<br>
+# CHECK: movb $-128, %al<br>
+<br>
+# CHECK: movw $32767, %ax # imm = 0x7FFF<br>
+# CHECK: movw $-32768, %ax # imm = 0xFFFFFFFFFFFF8000<br>
+<br>
+# CHECK: movl $2147483647, %eax # imm = 0x7FFFFFFF<br>
+# CHECK: movl $-<a href="tel:2147483648" value="+12147483648" target="_blank">2147483648</a>, %eax # imm = 0xFFFFFFFF80000000<br>
+<br>
+# CHECK: movabsq $9223372036854775807, %rax # imm = 0x7FFFFFFFFFFFFFFF<br>
+# CHECK: movabsq $-9223372036854775808, %rax # imm = 0x8000000000000000<br>
+<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><span><font color="#888888"><div dir="ltr">-- <br></div>Mike<br>Sent from phone
</font></span></blockquote></div><br></div>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><div dir="ltr">-- <br></div>Mike<br>Sent from phone
</div></div></blockquote></div><br></div>