<div dir="ltr">







<p class=""><span class="">derp, I was looking at the other getNode call, nevermind.</span></p></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 17, 2016 at 3:44 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, May 17, 2016 at 7:24 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Tue May 17 09:24:41 2016<br>
New Revision: 269767<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269767&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=269767&view=rev</a><br>
Log:<br>
[LCSSA] Use any_of() to simplify the code. NFCI.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Utils/LCSSA.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Utils/LCSSA.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LCSSA.cpp?rev=269767&r1=269766&r2=269767&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LCSSA.cpp?rev=269767&r1=269766&r2=269767&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Utils/LCSSA.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Utils/LCSSA.cpp Tue May 17 09:24:41 2016<br>
@@ -53,10 +53,8 @@ STATISTIC(NumLCSSA, "Number of live out<br>
 /// Return true if the specified block is in the list.<br>
 static bool isExitBlock(BasicBlock *BB,<br>
                         const SmallVectorImpl<BasicBlock *> &ExitBlocks) {<br>
-  for (unsigned i = 0, e = ExitBlocks.size(); i != e; ++i)<br>
-    if (ExitBlocks[i] == BB)<br>
-      return true;<br>
-  return false;<br>
+  return std::any_of(ExitBlocks.begin(), ExitBlocks.end(),<br>
+                     [&](BasicBlock *EB) { return EB == BB; });<br>
 }<br>
<br>
 /// Given an instruction in the loop, check to see if it has any uses that are<br>
@@ -210,11 +208,9 @@ blockDominatesAnExit(BasicBlock *BB,<br>
                      DominatorTree &DT,<br>
                      const SmallVectorImpl<BasicBlock *> &ExitBlocks) {<br>
   DomTreeNode *DomNode = DT.getNode(BB);<br>
-  for (BasicBlock *ExitBB : ExitBlocks)<br>
-    if (DT.dominates(DomNode, DT.getNode(ExitBB)))<br>
-      return true;<br>
-<br>
-  return false;<br>
+  return std::any_of(ExitBlocks.begin(), ExitBlocks.end(), [&](BasicBlock *EB) {<br>
+    return DT.dominates(DomNode, DT.getNode(EB));<br></blockquote><div><br></div></div></div><div>After this change, DT.getNode is evaluated every time through the loop instead of once at the beginning. Is that a problem?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+  });<br>
 }<br>
<br>
 bool llvm::formLCSSA(Loop &L, DominatorTree &DT, LoopInfo *LI,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>