<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 17, 2016, at 5:21 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, May 17, 2016 at 5:08 PM Mehdi Amini via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Seriously I absolutely don't get the "start a new revision" thing because the initial email was not on llvm-commit. Really what is the rational?<br class="">
<br class="">
We are losing the history and the threading for the review, this is really annoying.<br class="">
<br class="">
So big -1<br class=""></blockquote><div class=""><br class=""></div><div class="">I don't care very much about starting a new revision.</div><div class=""><br class=""></div><div class="">Justin and others who don't use phabricator asked for this because that is what causes an email with a patch file to be sent to llvm-commits, and so I've been trying to encourage it based on their request.</div></div></div></div></blockquote><div><br class=""></div><div><br class=""></div><div>There *has been* an email with a patch sent to llvm-commit after the first update to the diff: <a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160516/357163.html" class="">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160516/357163.html</a></div><div>Just "having a patch sent to llvm-commit" can be accomplished with an manual email answering to the revision instead of create a new one from scratch.</div><div><br class=""></div><div>That said the patch is always a mere two-clicks away from the email: <a href="http://reviews.llvm.org/D20260?download=true" class="">http://reviews.llvm.org/D20260?download=true</a></div><div>One could even write a plugin for his email client to act on link in the email "<a href="http://reviews.llvm.org/D20260" class="">http://reviews.llvm.org/D20260</a>" and automatically curl the latest patch.</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class="">There is still the fact that even the initial phab revision has essentially no context. I've skimmed thin three or four times and I'm not sure yet what the motivation is... I'm sure it has one, I just can't find it.</div></div></div></div></blockquote><div><br class=""></div><div>s/Initial phab revision/current phab revision/</div><div><br class=""></div><div>Yes, I'd expect a phabricator revision to have a correct description.</div><div><br class=""></div><div>-- </div><div>Mehdi</div><div><br class=""></div><br class=""><div><br class=""></div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
--<br class="">
Mehdi<br class="">
<br class="">
<br class="">
> On May 17, 2016, at 4:49 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank" class="">chandlerc@gmail.com</a>> wrote:<br class="">
><br class="">
> chandlerc added a subscriber: chandlerc.<br class="">
> chandlerc added a comment.<br class="">
><br class="">
> Folks, llvm-commits wasn't even on the original version of this patch, and there is essentially no high-level description of the problem being solved or the motivation of the patch.<br class="">
><br class="">
> Can you start a fresh revision in phab and actually include a *lot* more context? I suspect many, many people will be very interested in something as impactful as a new variant of 'unnamed_addr' and they may (like me) have completely missed the discussion taking place here or lack significant context for it.<br class="">
><br class="">
><br class="">
> <a href="http://reviews.llvm.org/D20260" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D20260</a><br class="">
><br class="">
><br class="">
><br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>