<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">It seems that our normal stage 1 builds are not running these test cases so it is not blocking other builds.<div class="">I think it should be fine to leave it failing for a while until Kuba can take a look. <div class="">Kuba, do you have time to look at it or should I XFAIL them for now?<div class=""><br class=""></div><div class="">Thanks</div><div class=""><br class=""></div><div class="">Steven</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 17, 2016, at 1:49 PM, Mike Aizatsky <<a href="mailto:aizatsky@chromium.org" class="">aizatsky@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Yes,<div class=""><br class=""></div><div class="">This is because I was trying to fix a memory leak that Kuba introduced. Rolling back all his stuff seems unrealistic (5 CLs at least). Since these CLs try to make Darwin work, I suggest to keep this build red until Kuba can address the issue. WDYT?</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, May 17, 2016 at 1:27 PM Steven Wu <<a href="mailto:stevenwu@apple.com" class="">stevenwu@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mike<br class="">
<br class="">
Your change breaks the Darwin bots: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1784/" rel="noreferrer" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1784/</a><br class="">
It seems you are not in the recipients of the failing email. Can you take a look at it?<br class="">
<br class="">
Thanks<br class="">
<br class="">
Steven<br class="">
<br class="">
> On May 17, 2016, at 11:44 AM, Mike Aizatsky via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: aizatsky<br class="">
> Date: Tue May 17 13:44:21 2016<br class="">
> New Revision: 269799<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269799&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=269799&view=rev</a><br class="">
> Log:<br class="">
> [sanitizers] disabling LateInitialize call to fix the build.<br class="">
><br class="">
> <a href="http://reviews.llvm.org/rL269291" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/rL269291</a> introduced a memory leak.<br class="">
> Disabling offending call temprorary rather than rolling back the chain<br class="">
> of CLs.<br class="">
><br class="">
> Modified:<br class="">
> compiler-rt/trunk/lib/asan/asan_rtl.cc<br class="">
> compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br class="">
><br class="">
> Modified: compiler-rt/trunk/lib/asan/asan_rtl.cc<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- compiler-rt/trunk/lib/asan/asan_rtl.cc (original)<br class="">
> +++ compiler-rt/trunk/lib/asan/asan_rtl.cc Tue May 17 13:44:21 2016<br class="">
> @@ -553,7 +553,8 @@ static void AsanInitInternal() {<br class="">
><br class="">
> InitializeSuppressions();<br class="">
><br class="">
> - Symbolizer::LateInitialize();<br class="">
> + // TODO(kuba) Fix Me.<br class="">
> + // Symbolizer::LateInitialize();<br class="">
><br class="">
> VReport(1, "AddressSanitizer Init done\n");<br class="">
> }<br class="">
><br class="">
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)<br class="">
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Tue May 17 13:44:21 2016<br class="">
> @@ -371,7 +371,8 @@ void Initialize(ThreadState *thr) {<br class="">
> ctx->initialized = true;<br class="">
><br class="">
> #ifndef SANITIZER_GO<br class="">
> - Symbolizer::LateInitialize();<br class="">
> + // TODO(kuba) Fix Me.<br class="">
> + // Symbolizer::LateInitialize();<br class="">
> #endif<br class="">
><br class="">
> if (flags()->stop_on_start) {<br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></div></body></html>