<div dir="ltr">Yes,<div><br></div><div>This is because I was trying to fix a memory leak that Kuba introduced. Rolling back all his stuff seems unrealistic (5 CLs at least). Since these CLs try to make Darwin work, I suggest to keep this build red until Kuba can address the issue. WDYT?</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, May 17, 2016 at 1:27 PM Steven Wu <<a href="mailto:stevenwu@apple.com">stevenwu@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mike<br>
<br>
Your change breaks the Darwin bots: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1784/" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1784/</a><br>
It seems you are not in the recipients of the failing email. Can you take a look at it?<br>
<br>
Thanks<br>
<br>
Steven<br>
<br>
> On May 17, 2016, at 11:44 AM, Mike Aizatsky via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: aizatsky<br>
> Date: Tue May 17 13:44:21 2016<br>
> New Revision: 269799<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269799&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=269799&view=rev</a><br>
> Log:<br>
> [sanitizers] disabling LateInitialize call to fix the build.<br>
><br>
> <a href="http://reviews.llvm.org/rL269291" rel="noreferrer" target="_blank">http://reviews.llvm.org/rL269291</a> introduced a memory leak.<br>
> Disabling offending call temprorary rather than rolling back the chain<br>
> of CLs.<br>
><br>
> Modified:<br>
>    compiler-rt/trunk/lib/asan/asan_rtl.cc<br>
>    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/asan/asan_rtl.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/asan/asan_rtl.cc (original)<br>
> +++ compiler-rt/trunk/lib/asan/asan_rtl.cc Tue May 17 13:44:21 2016<br>
> @@ -553,7 +553,8 @@ static void AsanInitInternal() {<br>
><br>
>   InitializeSuppressions();<br>
><br>
> -  Symbolizer::LateInitialize();<br>
> +  // TODO(kuba) Fix Me.<br>
> +  // Symbolizer::LateInitialize();<br>
><br>
>   VReport(1, "AddressSanitizer Init done\n");<br>
> }<br>
><br>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)<br>
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Tue May 17 13:44:21 2016<br>
> @@ -371,7 +371,8 @@ void Initialize(ThreadState *thr) {<br>
>   ctx->initialized = true;<br>
><br>
> #ifndef SANITIZER_GO<br>
> -  Symbolizer::LateInitialize();<br>
> +  // TODO(kuba) Fix Me.<br>
> +  // Symbolizer::LateInitialize();<br>
> #endif<br>
><br>
>   if (flags()->stop_on_start) {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div>