<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Any specific suggestions how to do that for SANITIZER_GO? Currently, SANITIZER_GO isn’t even guaranteed to be “0” or “1”, instead it’s either defined or not. That would be a simple change, but we’ll need to change all uses of SANITIZER_GO from #ifdef to #if.</div><div class=""><br class=""></div><div class="">Then it’s still not easy to just “if (SANITIZER_GO)”, because in this case (and plenty of others), we’ll just fail to link. The symbolizer stuff isn't built in a Go build. We *might* be able to link fine with -O<something> because the if(0) will be dead-code-removed, but that just makes the situation even worse (some configurations build, some don’t).</div><div class=""><br class=""></div><div class="">Kuba</div><br class=""><div><blockquote type="cite" class=""><div class="">On 12 May 2016, at 22:05, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, May 12, 2016 at 6:28 AM, Kuba Brecka via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: kuba.brecka<br class="">
Date: Thu May 12 08:28:45 2016<br class="">
New Revision: 269293<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269293&view=rev" rel="noreferrer" class="">http://llvm.org/viewvc/llvm-project?rev=269293&view=rev</a><br class="">
Log:<br class="">
Fixup for r269291, which broke the Go TSan build. Let's not use the symbolizer in Go builds.<br class="">
<br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br class="">
<br class="">
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269293&r1=269292&r2=269293&view=diff" rel="noreferrer" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269293&r1=269292&r2=269293&view=diff</a><br class="">
==============================================================================<br class="">
--- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)<br class="">
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Thu May 12 08:28:45 2016<br class="">
@@ -370,7 +370,9 @@ void Initialize(ThreadState *thr) {<br class="">
#endif<br class="">
ctx->initialized = true;<br class="">
<br class=""></blockquote><div class=""><br class=""></div><div class="">We have too many #ifndef SANITIZER_GO. </div><div class="">Can we replace at least some of them with if (!SANITIZER_GO)?</div><div class="">Pleeeeeeaseee. </div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
+#ifndef SANITIZER_GO<br class="">
Symbolizer::LateInitialize();<br class="">
+#endif<br class="">
<br class="">
if (flags()->stop_on_start) {<br class="">
Printf("ThreadSanitizer is suspended at startup (pid %d)."<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>