<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 12, 2016 at 6:28 AM, Kuba Brecka via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: kuba.brecka<br>
Date: Thu May 12 08:28:45 2016<br>
New Revision: 269293<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=269293&view=rev" rel="noreferrer">http://llvm.org/viewvc/llvm-project?rev=269293&view=rev</a><br>
Log:<br>
Fixup for r269291, which broke the Go TSan build.  Let's not use the symbolizer in Go builds.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269293&r1=269292&r2=269293&view=diff" rel="noreferrer">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269293&r1=269292&r2=269293&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Thu May 12 08:28:45 2016<br>
@@ -370,7 +370,9 @@ void Initialize(ThreadState *thr) {<br>
 #endif<br>
   ctx->initialized = true;<br>
<br></blockquote><div><br></div><div>We have too many #ifndef SANITIZER_GO. </div><div>Can we replace at least some of them with if (!SANITIZER_GO)?</div><div>Pleeeeeeaseee. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
+#ifndef SANITIZER_GO<br>
   Symbolizer::LateInitialize();<br>
+#endif<br>
<br>
   if (flags()->stop_on_start) {<br>
     Printf("ThreadSanitizer is suspended at startup (pid %d)."<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>