<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Great.  Thanks!<div class=""><br class=""></div><div class="">Pete<br class=""><div><blockquote type="cite" class=""><div class="">On May 6, 2016, at 12:23 PM, Xinliang David Li <<a href="mailto:davidxl@google.com" class="">davidxl@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I will revert the change for now.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, May 6, 2016 at 12:22 PM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Hi David<div class=""><br class=""></div><div class="">This is also failing on some of our internal bots.  Would it be possible to revert (or disable this for Darwin if its the only affected platform) while we work out the issue?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete<br class=""><div class=""><blockquote type="cite" class=""><div class=""><div class="h5"><div class="">On May 5, 2016, at 2:02 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>> wrote:</div><br class=""></div></div><div class=""><div class=""><div class="h5"><div style="word-wrap:break-word" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On May 5, 2016, at 11:53 AM, Xinliang David Li <<a href="mailto:davidxl@google.com" target="_blank" class="">davidxl@google.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Can you send me two files in : %t.ir.profdata and %t.ir.proftxt?</div></div></blockquote>Sure.  Here they are for x86_64.  Sorry, had to wait for a build to regenerate them</div><div class=""><br class=""></div><div class=""></div></div></div></div><span class=""><instrprof-value-prof.test.tmp.ir.proftxt></span><div style="word-wrap:break-word" class=""><div class=""></div></div><span class=""><instrprof-value-prof.test.tmp.profdata></span><div style="word-wrap:break-word" class=""><div class=""></div><div class=""><br class=""></div><div class="">BTW, assuming a build hasn’t cleaned them out, I was able to get these from the Jenkins workspace view.  That is, this view: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/ws/clang-build/projects/compiler-rt/test/profile/Profile-x86_64/Output/" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/ws/clang-build/projects/compiler-rt/test/profile/Profile-x86_64/Output/</a></div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete</div><div class=""><div class="h5"><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class=""><div class="">RUN: llvm-profdata merge -text  %t.ir.profdata -o %t.ir.proftxt </div><div class=""><br class=""></div></div><div class="">thanks,</div><div class=""><br class=""></div><div class="">David</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, May 5, 2016 at 11:46 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Hi David<div class=""><br class=""></div><div class="">I’m seeing a failure on the bots which appears to be from this commit.  Would you mind taking a look?</div><div class=""><br class=""></div><div class="">Also CCing Quentin as this is only failure on the GlobalISel bot which is weird as i can’t think of a reason for a difference in behaviour from the regular bots.</div><div class=""><br class=""></div><div class="">The log is here: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1544/console" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1544/console</a></div><div class=""><br class=""></div><div class="">And the error is:</div><div class=""><br class=""></div><div class=""><div class="">Exit Code: 1</div><div class=""><br class=""></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class=""><div class=""><div class="">Command Output (stderr):</div></div><div class=""><div class="">--</div></div><div class=""><br class=""></div><div class=""><div class="">/Users/buildslave/jenkins/sharedspace/clang-stage1-cmake-RA_workspace/llvm/projects/compiler-rt/test/profile/Inputs/instrprof-value-prof-real.c:46:8: error: expected string not found in input</div></div><div class=""><br class=""></div><div class=""><div class="">// IR: :ir</div></div><div class=""><div class="">       ^</div></div><div class=""><div class=""><stdin>:1:1: note: scanning from here</div></div><div class=""><div class="">foo_1_1_1_1_2_2_2_1_1</div></div><div class=""><div class="">^</div></div><div class=""><div class=""><stdin>:2:12: note: possible intended match here</div></div><div class=""><div class=""># Func Hash:</div></div></blockquote><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete</div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On May 4, 2016, at 10:41 PM, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div class="">Author: davidxl<br class="">Date: Thu May  5 00:41:02 2016<br class="">New Revision: 268608<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=268608&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=268608&view=rev</a><br class="">Log:<br class="">IR value profile testing cleanup <br class=""><br class="">Modified:<br class="">    compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c<br class="">    compiler-rt/trunk/test/profile/instrprof-value-prof.test<br class=""><br class="">Modified: compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c?rev=268608&r1=268607&r2=268608&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c?rev=268608&r1=268607&r2=268608&view=diff</a><br class="">==============================================================================<br class="">--- compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c (original)<br class="">+++ compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c Thu May  5 00:41:02 2016<br class="">@@ -43,7 +43,7 @@ int main() {<br class=""><br class="">   return 0;<br class=""> }<br class="">-<br class="">+// IR: :ir<br class=""> // CHECK-LABEL:  main:<br class=""> // CHECK:<span style="white-space:pre-wrap" class=""> </span>[ 0, foo_1_1_1_1_1_1_1_1_1, 1000 ]<br class=""> // CHECK-NEXT:<span style="white-space:pre-wrap" class="">       </span>[ 0, foo_1_1_1_1_1_1_1_1_2, 999 ]<br class=""><br class="">Modified: compiler-rt/trunk/test/profile/instrprof-value-prof.test<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/instrprof-value-prof.test?rev=268608&r1=268607&r2=268608&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/instrprof-value-prof.test?rev=268608&r1=268607&r2=268608&view=diff</a><br class="">==============================================================================<br class="">--- compiler-rt/trunk/test/profile/instrprof-value-prof.test (original)<br class="">+++ compiler-rt/trunk/test/profile/instrprof-value-prof.test Thu May  5 00:41:02 2016<br class="">@@ -3,9 +3,10 @@<br class=""> // RUN: llvm-profdata merge -o %t.profdata %t.profraw<br class=""> // RUN: llvm-profdata show --all-functions -ic-targets  %t.profdata | FileCheck  %S/Inputs/instrprof-value-prof-real.c<br class=""><br class="">-// do two step build before the clang option is ready<br class="">-// RUN: %clang -O2 -mllvm -disable-vp=false -Xclang -fprofile-instrument=llvm -c -o %t.ir.o  %S/Inputs/instrprof-value-prof-real.c<br class="">-// RUN: %clang_profgen -O2 -o %<a href="http://t.ir/" target="_blank" class="">t.ir</a>  %t.ir.o<br class="">+// IR level instrumentation<br class="">+// RUN: %clang_profgen -O2 -mllvm -disable-vp=false -Xclang -fprofile-instrument=llvm -o %<a href="http://t.ir/" target="_blank" class="">t.ir</a>  %S/Inputs/instrprof-value-prof-real.c<br class=""> // RUN: env LLVM_PROFILE_FILE=%t.ir.profraw %run %<a href="http://t.ir/" target="_blank" class="">t.ir</a><br class=""> // RUN: llvm-profdata merge -o %t.ir.profdata %t.ir.profraw<br class=""> // RUN: llvm-profdata show --all-functions -ic-targets  %t.ir.profdata | FileCheck  %S/Inputs/instrprof-value-prof-real.c<br class="">+// RUN: llvm-profdata merge -text  %t.ir.profdata -o %t.ir.proftxt <br class="">+// RUN: FileCheck  %S/Inputs/instrprof-value-prof-real.c --check-prefix=IR < %t.ir.proftxt<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>