<div dir="ltr">I will revert the change for now.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 6, 2016 at 12:22 PM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi David<div><br></div><div>This is also failing on some of our internal bots. Would it be possible to revert (or disable this for Darwin if its the only affected platform) while we work out the issue?</div><div><br></div><div>Thanks,</div><div>Pete<br><div><blockquote type="cite"><div><div class="h5"><div>On May 5, 2016, at 2:02 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>> wrote:</div><br></div></div><div><div><div class="h5"><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On May 5, 2016, at 11:53 AM, Xinliang David Li <<a href="mailto:davidxl@google.com" target="_blank">davidxl@google.com</a>> wrote:</div><br><div><div dir="ltr">Can you send me two files in : %t.ir.profdata and %t.ir.proftxt?</div></div></blockquote>Sure. Here they are for x86_64. Sorry, had to wait for a build to regenerate them</div><div><br></div><div></div></div></div></div><span><instrprof-value-prof.test.tmp.ir.proftxt></span><div style="word-wrap:break-word"><div></div></div><span><instrprof-value-prof.test.tmp.profdata></span><div style="word-wrap:break-word"><div></div><div><br></div><div>BTW, assuming a build hasn’t cleaned them out, I was able to get these from the Jenkins workspace view. That is, this view: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/ws/clang-build/projects/compiler-rt/test/profile/Profile-x86_64/Output/" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/ws/clang-build/projects/compiler-rt/test/profile/Profile-x86_64/Output/</a></div><div><br></div><div>Thanks,</div><div>Pete</div><div><div class="h5"><div><blockquote type="cite"><div><div dir="ltr"><div><br></div><div><div>RUN: llvm-profdata merge -text %t.ir.profdata -o %t.ir.proftxt </div><div><br></div></div><div>thanks,</div><div><br></div><div>David</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 5, 2016 at 11:46 AM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi David<div><br></div><div>I’m seeing a failure on the bots which appears to be from this commit. Would you mind taking a look?</div><div><br></div><div>Also CCing Quentin as this is only failure on the GlobalISel bot which is weird as i can’t think of a reason for a difference in behaviour from the regular bots.</div><div><br></div><div>The log is here: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1544/console" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1544/console</a></div><div><br></div><div>And the error is:</div><div><br></div><div><div>Exit Code: 1</div><div><br></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>Command Output (stderr):</div></div><div><div>--</div></div><div><br></div><div><div>/Users/buildslave/jenkins/sharedspace/clang-stage1-cmake-RA_workspace/llvm/projects/compiler-rt/test/profile/Inputs/instrprof-value-prof-real.c:46:8: error: expected string not found in input</div></div><div><br></div><div><div>// IR: :ir</div></div><div><div> ^</div></div><div><div><stdin>:1:1: note: scanning from here</div></div><div><div>foo_1_1_1_1_2_2_2_1_1</div></div><div><div>^</div></div><div><div><stdin>:2:12: note: possible intended match here</div></div><div><div># Func Hash:</div></div></blockquote><div><br></div><div>Thanks,</div><div>Pete</div><div><div><blockquote type="cite"><div>On May 4, 2016, at 10:41 PM, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div>Author: davidxl<br>Date: Thu May 5 00:41:02 2016<br>New Revision: 268608<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=268608&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=268608&view=rev</a><br>Log:<br>IR value profile testing cleanup <br><br>Modified:<br> compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c<br> compiler-rt/trunk/test/profile/instrprof-value-prof.test<br><br>Modified: compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c<br>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c?rev=268608&r1=268607&r2=268608&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c?rev=268608&r1=268607&r2=268608&view=diff</a><br>==============================================================================<br>--- compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c (original)<br>+++ compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c Thu May 5 00:41:02 2016<br>@@ -43,7 +43,7 @@ int main() {<br><br> return 0;<br> }<br>-<br>+// IR: :ir<br> // CHECK-LABEL: main:<br> // CHECK:<span style="white-space:pre-wrap"> </span>[ 0, foo_1_1_1_1_1_1_1_1_1, 1000 ]<br> // CHECK-NEXT:<span style="white-space:pre-wrap"> </span>[ 0, foo_1_1_1_1_1_1_1_1_2, 999 ]<br><br>Modified: compiler-rt/trunk/test/profile/instrprof-value-prof.test<br>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/instrprof-value-prof.test?rev=268608&r1=268607&r2=268608&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/instrprof-value-prof.test?rev=268608&r1=268607&r2=268608&view=diff</a><br>==============================================================================<br>--- compiler-rt/trunk/test/profile/instrprof-value-prof.test (original)<br>+++ compiler-rt/trunk/test/profile/instrprof-value-prof.test Thu May 5 00:41:02 2016<br>@@ -3,9 +3,10 @@<br> // RUN: llvm-profdata merge -o %t.profdata %t.profraw<br> // RUN: llvm-profdata show --all-functions -ic-targets %t.profdata | FileCheck %S/Inputs/instrprof-value-prof-real.c<br><br>-// do two step build before the clang option is ready<br>-// RUN: %clang -O2 -mllvm -disable-vp=false -Xclang -fprofile-instrument=llvm -c -o %t.ir.o %S/Inputs/instrprof-value-prof-real.c<br>-// RUN: %clang_profgen -O2 -o %<a href="http://t.ir/" target="_blank">t.ir</a> %t.ir.o<br>+// IR level instrumentation<br>+// RUN: %clang_profgen -O2 -mllvm -disable-vp=false -Xclang -fprofile-instrument=llvm -o %<a href="http://t.ir/" target="_blank">t.ir</a> %S/Inputs/instrprof-value-prof-real.c<br> // RUN: env LLVM_PROFILE_FILE=%t.ir.profraw %run %<a href="http://t.ir/" target="_blank">t.ir</a><br> // RUN: llvm-profdata merge -o %t.ir.profdata %t.ir.profraw<br> // RUN: llvm-profdata show --all-functions -ic-targets %t.ir.profdata | FileCheck %S/Inputs/instrprof-value-prof-real.c<br>+// RUN: llvm-profdata merge -text %t.ir.profdata -o %t.ir.proftxt <br>+// RUN: FileCheck %S/Inputs/instrprof-value-prof-real.c --check-prefix=IR < %t.ir.proftxt<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></div></blockquote></div><br></div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div></blockquote></div><br></div>