<div dir="ltr">Sure. I'd prefer to merge up into TargetMachine rather than calling it LLVMTargetMachine.<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 5, 2016 at 7:48 AM Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Awesome.<br>
<br>
BTW, now the only thing that inherits from TargetMachine is<br>
LLVMTargetMachine. Should we merge the two?<br>
<br>
Cheers,<br>
Rafael<br>
<br>
<br>
On 5 May 2016 at 10:35, James Y Knight via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: jyknight<br>
> Date: Thu May 5 09:35:40 2016<br>
> New Revision: 268631<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=268631&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=268631&view=rev</a><br>
> Log:<br>
> Remove bit-rotten CppBackend.<br>
><br>
> This backend was supposed to generate C++ code which will re-construct<br>
> the LLVM IR passed as input. This seems to me to have very marginal<br>
> usefulness in the first place.<br>
><br>
> However, the code has never been updated to use IRBuilder, which makes<br>
> its current value negative -- people who look at the output may be<br>
> steered to use the *wrong* C++ APIs to construct IR.<br>
><br>
> Furthermore, it's generated code that doesn't compile since at least<br>
> 2013.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D19942" rel="noreferrer" target="_blank">http://reviews.llvm.org/D19942</a><br>
><br>
> Removed:<br>
> llvm/trunk/lib/Target/CppBackend/<br>
> llvm/trunk/test/CodeGen/CPP/<br>
> Modified:<br>
> llvm/trunk/CMakeLists.txt<br>
> llvm/trunk/docs/CodeGenerator.rst<br>
> llvm/trunk/docs/GettingStarted.rst<br>
> llvm/trunk/lib/Target/LLVMBuild.txt<br>
> llvm/trunk/utils/GenLibDeps.pl<br>
><br>
> Modified: llvm/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=268631&r1=268630&r2=268631&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=268631&r1=268630&r2=268631&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/CMakeLists.txt (original)<br>
> +++ llvm/trunk/CMakeLists.txt Thu May 5 09:35:40 2016<br>
> @@ -226,7 +226,6 @@ set(LLVM_ALL_TARGETS<br>
> AMDGPU<br>
> ARM<br>
> BPF<br>
> - CppBackend<br>
> Hexagon<br>
> Mips<br>
> MSP430<br>
><br>
> Modified: llvm/trunk/docs/CodeGenerator.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CodeGenerator.rst?rev=268631&r1=268630&r2=268631&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CodeGenerator.rst?rev=268631&r1=268630&r2=268631&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/docs/CodeGenerator.rst (original)<br>
> +++ llvm/trunk/docs/CodeGenerator.rst Thu May 5 09:35:40 2016<br>
> @@ -1771,13 +1771,11 @@ table that summarizes what features are<br>
> Target Feature Matrix<br>
> ---------------------<br>
><br>
> -Note that this table does not include the C backend or Cpp backends, since they<br>
> -do not use the target independent code generator infrastructure. It also<br>
> -doesn't list features that are not supported fully by any target yet. It<br>
> -considers a feature to be supported if at least one subtarget supports it. A<br>
> -feature being supported means that it is useful and works for most cases, it<br>
> -does not indicate that there are zero known bugs in the implementation. Here is<br>
> -the key:<br>
> +Note that this table does not list features that are not supported fully by any<br>
> +target yet. It considers a feature to be supported if at least one subtarget<br>
> +supports it. A feature being supported means that it is useful and works for<br>
> +most cases, it does not indicate that there are zero known bugs in the<br>
> +implementation. Here is the key:<br>
><br>
> :raw-html:`<table border="1" cellspacing="0">`<br>
> :raw-html:`<tr>`<br>
><br>
> Modified: llvm/trunk/docs/GettingStarted.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/GettingStarted.rst?rev=268631&r1=268630&r2=268631&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/GettingStarted.rst?rev=268631&r1=268630&r2=268631&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/docs/GettingStarted.rst (original)<br>
> +++ llvm/trunk/docs/GettingStarted.rst Thu May 5 09:35:40 2016<br>
> @@ -730,9 +730,9 @@ used by people developing LLVM.<br>
> | | the configure script. The default list is defined |<br>
> | | as ``LLVM_ALL_TARGETS``, and can be set to include |<br>
> | | out-of-tree targets. The default value includes: |<br>
> -| | ``AArch64, AMDGPU, ARM, BPF, CppBackend, Hexagon, |<br>
> -| | Mips, MSP430, NVPTX, PowerPC, Sparc, SystemZ |<br>
> -| | X86, XCore``. |<br>
> +| | ``AArch64, AMDGPU, ARM, BPF, Hexagon, Mips, |<br>
> +| | MSP430, NVPTX, PowerPC, Sparc, SystemZ, X86, |<br>
> +| | XCore``. |<br>
> +-------------------------+----------------------------------------------------+<br>
> | LLVM_ENABLE_DOXYGEN | Build doxygen-based documentation from the source |<br>
> | | code This is disabled by default because it is |<br>
><br>
> Modified: llvm/trunk/lib/Target/LLVMBuild.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/LLVMBuild.txt?rev=268631&r1=268630&r2=268631&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/LLVMBuild.txt?rev=268631&r1=268630&r2=268631&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/LLVMBuild.txt (original)<br>
> +++ llvm/trunk/lib/Target/LLVMBuild.txt Thu May 5 09:35:40 2016<br>
> @@ -24,7 +24,6 @@ subdirectories =<br>
> AArch64<br>
> AVR<br>
> BPF<br>
> - CppBackend<br>
> Lanai<br>
> Hexagon<br>
> MSP430<br>
><br>
> Modified: llvm/trunk/utils/GenLibDeps.pl<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/GenLibDeps.pl?rev=268631&r1=268630&r2=268631&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/GenLibDeps.pl?rev=268631&r1=268630&r2=268631&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/GenLibDeps.pl (original)<br>
> +++ llvm/trunk/utils/GenLibDeps.pl Thu May 5 09:35:40 2016<br>
> @@ -96,7 +96,6 @@ if ($PEROBJ) {<br>
> $libpath =~ s/^AsmPrinter/CodeGen\/AsmPrinter/;<br>
> $libpath =~ s/^BitReader/Bitcode\/Reader/;<br>
> $libpath =~ s/^BitWriter/Bitcode\/Writer/;<br>
> - $libpath =~ s/^CppBackend/Target\/CppBackend/;<br>
> $libpath =~ s/^MSIL/Target\/MSIL/;<br>
> $libpath =~ s/^Core/IR/;<br>
> $libpath =~ s/^Instrumentation/Transforms\/Instrumentation/;<br>
> @@ -137,7 +136,6 @@ if ($PEROBJ) {<br>
> $libpath =~ s/^AsmPrinter/CodeGen\/AsmPrinter/;<br>
> $libpath =~ s/^BitReader/Bitcode\/Reader/;<br>
> $libpath =~ s/^BitWriter/Bitcode\/Writer/;<br>
> - $libpath =~ s/^CppBackend/Target\/CppBackend/;<br>
> $libpath =~ s/^MSIL/Target\/MSIL/;<br>
> $libpath =~ s/^Core/VMCore/;<br>
> $libpath =~ s/^Instrumentation/Transforms\/Instrumentation/;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>