<p dir="ltr">Not sure the parenthesis are needed given the string is always true.<br>
</p>
<div class="gmail_quote">On May 3, 2016 3:38 AM, "Davide Italiano" <<a href="mailto:davide@freebsd.org">davide@freebsd.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, May 2, 2016 at 2:06 PM, Rafael Espindola via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: rafael<br>
> Date: Mon May  2 16:06:57 2016<br>
> New Revision: 268305<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=268305&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=268305&view=rev</a><br>
> Log:<br>
> Don't try to create thin bsd archives.<br>
><br>
> Not such variant has been specified yet.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Object/ArchiveWriter.cpp<br>
>     llvm/trunk/test/Object/archive-format.test<br>
>     llvm/trunk/tools/llvm-ar/llvm-ar.cpp<br>
><br>
> Modified: llvm/trunk/lib/Object/ArchiveWriter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=268305&r1=268304&r2=268305&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=268305&r1=268304&r2=268305&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Object/ArchiveWriter.cpp (original)<br>
> +++ llvm/trunk/lib/Object/ArchiveWriter.cpp Mon May  2 16:06:57 2016<br>
> @@ -308,6 +308,9 @@ llvm::writeArchive(StringRef ArcName,<br>
>                     std::vector<NewArchiveIterator> &NewMembers,<br>
>                     bool WriteSymtab, object::Archive::Kind Kind,<br>
>                     bool Deterministic, bool Thin) {<br>
> +  assert(!Thin ||<br>
> +         Kind == object::Archive::K_GNU &&<br>
> +             "Only the gnu format has a thin mode");<br>
>    SmallString<128> TmpArchive;<br>
>    int TmpArchiveFD;<br>
<br>
I think this lacks a pair of ().<br>
I went ahead and tried to fix in r268367. Hope this is what you<br>
intended to assert.<br>
<br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</blockquote></div>