<div dir="ltr">What does the actual output look like?<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 28, 2016 at 1:57 AM, Ismail Donmez via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<div><div class="h5"><br>
On Thu, Apr 28, 2016 at 2:20 AM, Rong Xu via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: xur<br>
> Date: Wed Apr 27 18:20:27 2016<br>
> New Revision: 267815<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=267815&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=267815&view=rev</a><br>
> Log:<br>
> [PGO] Promote indirect calls to conditional direct calls with value-profile<br>
><br>
> This patch implements the transformation that promotes indirect calls to<br>
> conditional direct calls when the indirect-call value profile meta-data is<br>
> available.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D17864" rel="noreferrer" target="_blank">http://reviews.llvm.org/D17864</a><br>
><br>
> Added:<br>
>     llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp<br>
>     llvm/trunk/test/Transforms/PGOProfile/icp_covariant_call_return.ll<br>
>     llvm/trunk/test/Transforms/PGOProfile/icp_covariant_invoke_return.ll<br>
>     llvm/trunk/test/Transforms/PGOProfile/icp_invoke.ll<br>
>     llvm/trunk/test/Transforms/PGOProfile/icp_mismatch_msg.ll<br>
>     llvm/trunk/test/Transforms/PGOProfile/icp_vararg.ll<br>
>     llvm/trunk/test/Transforms/PGOProfile/indirect_call_promotion.ll<br>
> Modified:<br>
>     llvm/trunk/include/llvm/InitializePasses.h<br>
>     llvm/trunk/include/llvm/LinkAllPasses.h<br>
>     llvm/trunk/include/llvm/Transforms/Instrumentation.h<br>
>     llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
>     llvm/trunk/lib/Transforms/Instrumentation/CMakeLists.txt<br>
>     llvm/trunk/lib/Transforms/Instrumentation/Instrumentation.cpp<br>
<br>
</div></div>Fails with VS2015 x64:<br>
<br>
C:\cygwin64\home\ismail\src\llvm\test\Transforms\PGOProfile\icp_mismatch_msg.ll:3:10:<br>
error: expected string not found in input<br>
<span class="">; CHECK: remark: <unknown>:0:0: Cannot promote indirect call to func4<br>
with count of 1234: The number of arguments mismatch<br>
</span>         ^<br>
<stdin>:1:1: note: scanning from here<br>
remark: <unknown>:0:0: : The number of arguments mismatch<br>
^<br>
<br>
C:\cygwin64\home\ismail\src\llvm\test\Transforms\PGOProfile\indirect_call_promotion.ll:3:16:<br>
error: expected string not found in input<br>
<span class="">; PASS-REMARK: remark: <unknown>:0:0: Promote indirect call to func4<br>
with count 1030 out of 1600<br>
</span>               ^<br>
<stdin>:1:1: note: scanning from here<br>
remark: <unknown>:0:0: 1600<br>
^<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>