<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">I think it is actually needed because error() is not a noreturn function. We don't want to call addFile with the empty string.</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Sun, Apr 24, 2016 at 12:19 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Sun Apr 24 02:19:32 2016<br>
New Revision: 267333<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=267333&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=267333&view=rev</a><br>
Log:<br>
[ELF] Simplify. Remove unneeded else. NFC.<br>
<br>
Modified:<br>
lld/trunk/ELF/Driver.cpp<br>
<br>
Modified: lld/trunk/ELF/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=267333&r1=267332&r2=267333&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=267333&r1=267332&r2=267333&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Driver.cpp (original)<br>
+++ lld/trunk/ELF/Driver.cpp Sun Apr 24 02:19:32 2016<br>
@@ -151,8 +151,7 @@ void LinkerDriver::addLibrary(StringRef<br>
std::string Path = searchLibrary(Name);<br>
if (Path.empty())<br>
error("unable to find library -l" + Name);<br>
- else<br>
- addFile(Path);<br>
+ addFile(Path);<br>
}<br>
<br>
// This function is called on startup. We need this for LTO since<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>