<div dir="ltr">Generally a test case would be nice - especially if it's as simple as just not having a certain section (so it doesn't require a lot of complexity, etc).</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 21, 2016 at 12:49 PM, Kevin Enderby via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enderby<br>
Date: Thu Apr 21 14:49:29 2016<br>
New Revision: 267037<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=267037&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=267037&view=rev</a><br>
Log:<br>
Fix crash in llvm-objdump with -macho -objc-meta-data that was trying dump a non-existent section.<br>
<br>
Showed up in running on a large binary with the missing section.  I could create a fake<br>
test case if anyone really wants but the fix is pretty obvious.<br>
<br>
rdar://25837034<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-objdump/MachODump.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=267037&r1=267036&r2=267037&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=267037&r1=267036&r2=267037&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)<br>
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Thu Apr 21 14:49:29 2016<br>
@@ -5134,6 +5134,9 @@ static void print_image_info32(SectionRe<br>
   struct objc_image_info32 o;<br>
   const char *r;<br>
<br>
+  if (S == SectionRef())<br>
+    return;<br>
+<br>
   StringRef SectName;<br>
   S.getName(SectName);<br>
   DataRefImpl Ref = S.getRawDataRefImpl();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>