<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 21, 2016 at 3:16 PM, Zachary Turner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Thu Apr 21 17:16:19 2016<br>
New Revision: 267068<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=267068&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=267068&view=rev</a><br>
Log:<br>
Fix -Wreturn-type warning with HAVE_DIA_SDK is false.<br>
<br>
Modified:<br>
    llvm/trunk/lib/DebugInfo/PDB/PDB.cpp<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/PDB/PDB.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/PDB.cpp?rev=267068&r1=267067&r2=267068&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/PDB.cpp?rev=267068&r1=267067&r2=267068&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/PDB/PDB.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/PDB/PDB.cpp Thu Apr 21 17:16:19 2016<br>
@@ -30,6 +30,7 @@ PDB_ErrorCode llvm::loadDataForPDB(PDB_R<br>
 #if HAVE_DIA_SDK<br>
   return DIASession::createFromPdb(Path, Session);<br>
 #endif<br>
+       return PDB_ErrorCode::NoDiaSupport;<br></blockquote><div><br></div><div>Formatting? (looks like too many spaces - maybe that's a tab?)<br><br>Also, it might be best to use #else so that the second return isn't dead code (could produce a warning on a better compiler, maybe).<br>Could even:<br><br>  return</div><div>#if HAVE_DIA_SDK<br>    DIASession::createFromPdb(...);<br>#else<br>    PDB_ErrorCode::NoDiaSupport;<br>#endif<br><br>if that seems better... dunno.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 PDB_ErrorCode llvm::loadDataForEXE(PDB_ReaderType Type, StringRef Path,<br>
@@ -41,4 +42,5 @@ PDB_ErrorCode llvm::loadDataForEXE(PDB_R<br>
 #if HAVE_DIA_SDK<br>
   return DIASession::createFromExe(Path, Session);<br>
 #endif<br>
+       return PDB_ErrorCode::NoDiaSupport;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>