<div dir="ltr">Oops - yeah, this should have been deferring to the base-class assignment operator. Actually the assignment operator is not needed at all though - I'm just going to delete it for now.<div><br></div><div>- Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 19, 2016 at 1:03 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Apr 19, 2016 at 12:35 PM, Lang Hames via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Tue Apr 19 14:35:16 2016<br>
New Revision: 266805<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=266805&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=266805&view=rev</a><br>
Log:<br>
[Orc] Add explicit move ops to OrcRemoteTargetRPCAPI for MSVC.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h?rev=266805&r1=266804&r2=266805&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h?rev=266805&r1=266804&r2=266805&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h Tue Apr 19 14:35:16 2016<br>
@@ -85,6 +85,17 @@ protected:<br>
   };<br>
<br>
 public:<br>
+<br>
+  // FIXME: Remove constructors once MSVC supports synthesizing move-ops.<br>
+  OrcRemoteTargetRPCAPI() = default;<br>
+  OrcRemoteTargetRPCAPI(const OrcRemoteTargetRPCAPI&) = delete;<br>
+  OrcRemoteTargetRPCAPI& operator=(const OrcRemoteTargetRPCAPI&) = delete;<br>
+<br>
+  OrcRemoteTargetRPCAPI(OrcRemoteTargetRPCAPI&&) {}<br>
+  OrcRemoteTargetRPCAPI& operator=(OrcRemoteTargetRPCAPI&&) {<br>
+    return *this;<br>
+  }<br></blockquote><div><br></div></div></div><div>This seems strange - if it has no state, it should be implicitly copyable & that should be harmless, right? (& you could use the copy ctor from other move ops freely/harmlessly)</div><span class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
   enum JITFuncId : uint32_t {<br>
     InvalidId = RPCFunctionIdTraits<JITFuncId>::InvalidId,<br>
     CallIntVoidId = RPCFunctionIdTraits<JITFuncId>::FirstValidId,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>