<p dir="ltr">This looks awesome, but maybe split this in two? One changes all uses and another does the removal just in case we find something in another project?</p>
<div class="gmail_quote">On Apr 14, 2016 1:41 AM, "Mehdi AMINI via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joker.eph updated this revision to Diff 53660.<br>
joker.eph added a comment.<br>
<br>
Add missing extern "C" in fwd-decl.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D19094" rel="noreferrer" target="_blank">http://reviews.llvm.org/D19094</a><br>
<br>
Files:<br>
  bindings/ocaml/llvm/llvm.mli<br>
  docs/ProgrammersManual.rst<br>
  docs/ReleaseNotes.rst<br>
  docs/tutorial/LangImpl3.rst<br>
  docs/tutorial/LangImpl4.rst<br>
  docs/tutorial/LangImpl5.rst<br>
  docs/tutorial/LangImpl6.rst<br>
  docs/tutorial/LangImpl7.rst<br>
  examples/BrainF/BrainFDriver.cpp<br>
  examples/ExceptionDemo/ExceptionDemo.cpp<br>
  examples/Kaleidoscope/Chapter3/toy.cpp<br>
  examples/Kaleidoscope/Chapter4/toy.cpp<br>
  examples/Kaleidoscope/Chapter5/toy.cpp<br>
  examples/Kaleidoscope/Chapter6/toy.cpp<br>
  examples/Kaleidoscope/Chapter7/toy.cpp<br>
  examples/Kaleidoscope/Chapter8/toy.cpp<br>
  examples/Kaleidoscope/MCJIT/cached/toy-jit.cpp<br>
  examples/Kaleidoscope/MCJIT/cached/toy.cpp<br>
  examples/Kaleidoscope/MCJIT/complete/toy.cpp<br>
  examples/Kaleidoscope/MCJIT/initial/toy.cpp<br>
  examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp<br>
  examples/Kaleidoscope/MCJIT/lazy/toy.cpp<br>
  examples/Kaleidoscope/Orc/fully_lazy/toy.cpp<br>
  examples/Kaleidoscope/Orc/initial/toy.cpp<br>
  examples/Kaleidoscope/Orc/lazy_codegen/toy.cpp<br>
  examples/Kaleidoscope/Orc/lazy_irgen/toy.cpp<br>
  include/llvm/IR/LLVMContext.h<br>
  include/llvm/LinkAllIR.h<br>
  lib/Bitcode/Reader/BitReader.cpp<br>
  lib/IR/Core.cpp<br>
  lib/IR/LLVMContext.cpp<br>
  lib/Target/CppBackend/CPPBackend.cpp<br>
  lib/Target/Target.cpp<br>
  tools/bugpoint/bugpoint.cpp<br>
  tools/llc/llc.cpp<br>
  tools/lli/lli.cpp<br>
  tools/llvm-as-fuzzer/llvm-as-fuzzer.cpp<br>
  tools/llvm-as/llvm-as.cpp<br>
  tools/llvm-dis/llvm-dis.cpp<br>
  tools/llvm-extract/llvm-extract.cpp<br>
  tools/llvm-jitlistener/llvm-jitlistener.cpp<br>
  tools/llvm-link/llvm-link.cpp<br>
  tools/llvm-nm/llvm-nm.cpp<br>
  tools/llvm-profdata/llvm-profdata.cpp<br>
  tools/llvm-split/llvm-split.cpp<br>
  tools/llvm-stress/llvm-stress.cpp<br>
  tools/lto/lto.cpp<br>
  tools/opt/opt.cpp<br>
  tools/verify-uselistorder/verify-uselistorder.cpp<br>
  unittests/Analysis/AliasAnalysisTest.cpp<br>
  unittests/Analysis/BlockFrequencyInfoTest.cpp<br>
  unittests/Analysis/CFGTest.cpp<br>
  unittests/Analysis/CGSCCPassManagerTest.cpp<br>
  unittests/Analysis/CallGraphTest.cpp<br>
  unittests/Analysis/LazyCallGraphTest.cpp<br>
  unittests/Analysis/LoopPassManagerTest.cpp<br>
  unittests/Analysis/UnrollAnalyzer.cpp<br>
  unittests/Analysis/ValueTrackingTest.cpp<br>
  unittests/AsmParser/AsmParserTest.cpp<br>
  unittests/Bitcode/BitReaderTest.cpp<br>
  unittests/ExecutionEngine/ExecutionEngineTest.cpp<br>
  unittests/ExecutionEngine/Orc/IndirectionUtilsTest.cpp<br>
  unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp<br>
  unittests/ExecutionEngine/Orc/OrcCAPITest.cpp<br>
  unittests/ExecutionEngine/Orc/OrcTestCommon.h<br>
  unittests/IR/ConstantsTest.cpp<br>
  unittests/IR/DominatorTreeTest.cpp<br>
  unittests/IR/InstructionsTest.cpp<br>
  unittests/IR/LegacyPassManagerTest.cpp<br>
  unittests/IR/MetadataTest.cpp<br>
  unittests/IR/PassManagerTest.cpp<br>
  unittests/IR/TypeBuilderTest.cpp<br>
  unittests/IR/UserTest.cpp<br>
  unittests/IR/ValueHandleTest.cpp<br>
  unittests/IR/ValueMapTest.cpp<br>
  unittests/IR/ValueTest.cpp<br>
  unittests/IR/VerifierTest.cpp<br>
  unittests/IR/WaymarkTest.cpp<br>
  unittests/ProfileData/InstrProfTest.cpp<br>
  unittests/ProfileData/SampleProfTest.cpp<br>
  unittests/Transforms/Utils/IntegerDivision.cpp<br>
  unittests/Transforms/Utils/Local.cpp<br>
  unittests/Transforms/Utils/MemorySSA.cpp<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div>