<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Sure it makes sense to split before commit!<div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 14, 2016, at 9:57 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">This looks awesome, but maybe split this in two? One changes all uses and another does the removal just in case we find something in another project?</p><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Apr 14, 2016 1:41 AM, "Mehdi AMINI via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">joker.eph updated this revision to Diff 53660.<br class="">joker.eph added a comment.<br class=""><br class="">Add missing extern "C" in fwd-decl.<br class=""><br class=""><br class=""><a href="http://reviews.llvm.org/D19094" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D19094</a><br class=""><br class="">Files:<br class=""> <span class="Apple-converted-space"> </span>bindings/ocaml/llvm/llvm.mli<br class=""> <span class="Apple-converted-space"> </span>docs/ProgrammersManual.rst<br class=""> <span class="Apple-converted-space"> </span>docs/ReleaseNotes.rst<br class=""> <span class="Apple-converted-space"> </span>docs/tutorial/LangImpl3.rst<br class=""> <span class="Apple-converted-space"> </span>docs/tutorial/LangImpl4.rst<br class=""> <span class="Apple-converted-space"> </span>docs/tutorial/LangImpl5.rst<br class=""> <span class="Apple-converted-space"> </span>docs/tutorial/LangImpl6.rst<br class=""> <span class="Apple-converted-space"> </span>docs/tutorial/LangImpl7.rst<br class=""> <span class="Apple-converted-space"> </span>examples/BrainF/BrainFDriver.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/ExceptionDemo/ExceptionDemo.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter3/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter4/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter5/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter6/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter7/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Chapter8/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/cached/toy-jit.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/cached/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/complete/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/initial/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/lazy/toy-jit.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/MCJIT/lazy/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Orc/fully_lazy/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Orc/initial/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Orc/lazy_codegen/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>examples/Kaleidoscope/Orc/lazy_irgen/toy.cpp<br class=""> <span class="Apple-converted-space"> </span>include/llvm/IR/LLVMContext.h<br class=""> <span class="Apple-converted-space"> </span>include/llvm/LinkAllIR.h<br class=""> <span class="Apple-converted-space"> </span>lib/Bitcode/Reader/BitReader.cpp<br class=""> <span class="Apple-converted-space"> </span>lib/IR/Core.cpp<br class=""> <span class="Apple-converted-space"> </span>lib/IR/LLVMContext.cpp<br class=""> <span class="Apple-converted-space"> </span>lib/Target/CppBackend/CPPBackend.cpp<br class=""> <span class="Apple-converted-space"> </span>lib/Target/Target.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/bugpoint/bugpoint.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llc/llc.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/lli/lli.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-as-fuzzer/llvm-as-fuzzer.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-as/llvm-as.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-dis/llvm-dis.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-extract/llvm-extract.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-jitlistener/llvm-jitlistener.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-link/llvm-link.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-nm/llvm-nm.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-profdata/llvm-profdata.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-split/llvm-split.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/llvm-stress/llvm-stress.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/lto/lto.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/opt/opt.cpp<br class=""> <span class="Apple-converted-space"> </span>tools/verify-uselistorder/verify-uselistorder.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/AliasAnalysisTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/BlockFrequencyInfoTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/CFGTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/CGSCCPassManagerTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/CallGraphTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/LazyCallGraphTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/LoopPassManagerTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/UnrollAnalyzer.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Analysis/ValueTrackingTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/AsmParser/AsmParserTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Bitcode/BitReaderTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ExecutionEngine/ExecutionEngineTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ExecutionEngine/Orc/IndirectionUtilsTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ExecutionEngine/Orc/OrcCAPITest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ExecutionEngine/Orc/OrcTestCommon.h<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/ConstantsTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/DominatorTreeTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/InstructionsTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/LegacyPassManagerTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/MetadataTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/PassManagerTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/TypeBuilderTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/UserTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/ValueHandleTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/ValueMapTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/ValueTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/VerifierTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/IR/WaymarkTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ProfileData/InstrProfTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/ProfileData/SampleProfTest.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Transforms/Utils/IntegerDivision.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Transforms/Utils/Local.cpp<br class=""> <span class="Apple-converted-space"> </span>unittests/Transforms/Utils/MemorySSA.cpp<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></div></body></html>