<div dir="ltr">Added some text in r266225 (eventually I'll have to do a proper error handling pass over the whole thing - obviously it's easy to construct an input that would trigger that assertion, which isn't ideal/correct behavior)</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 5, 2016 at 3:19 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
+  assert(Form == dwarf::DW_FORM_GNU_str_index);<br></blockquote><div><br></div></span><div>Text after asserts is cool. :)</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-eric</div></font></span><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+  auto StrIndex = InfoData.getULEB128(&InfoOffset);<br>
   DataExtractor StrOffsetsData(StrOffsets, true, 0);<br>
   uint32_t StrOffsetsOffset = 4 * StrIndex;<br>
   uint32_t StrOffset = StrOffsetsData.getU32(&StrOffsetsOffset);<br>
@@ -163,12 +168,11 @@ static CompileUnitIdentifiers getCUIdent<br>
          (Name != 0 || Form != 0)) {<br>
     switch (Name) {<br>
     case dwarf::DW_AT_name: {<br>
-      ID.Name = getIndexedString(InfoData.getULEB128(&Offset), StrOffsets, Str);<br>
+      ID.Name = getIndexedString(Form, InfoData, Offset, StrOffsets, Str);<br>
       break;<br>
     }<br>
     case dwarf::DW_AT_GNU_dwo_name: {<br>
-      ID.DWOName =<br>
-          getIndexedString(InfoData.getULEB128(&Offset), StrOffsets, Str);<br>
+      ID.DWOName = getIndexedString(Form, InfoData, Offset, StrOffsets, Str);<br>
       break;<br>
     }<br>
     case dwarf::DW_AT_GNU_dwo_id:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div></div>
</blockquote></div><br></div>