<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">When llvm-ranlib is run without arguments, it prints out the following error message:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">llvm-ranlib.exe: llvm-ranlib.exetakes just one archive as argument<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">My patch fixes this up a little by adding a space between the “llvm-ranlib.exe” and “takes”, as well as adds the word “an” between the words “an” and “argument”. With my patch, the error message would look like this:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">llvm-ranlib.exe: llvm-ranlib.exe takes just one archive as an argument<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This change is NFC.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Here is the simple patch:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:Consolas">Index: tools/llvm-ar/llvm-ar.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">===================================================================<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">--- tools/llvm-ar/llvm-ar.cpp (revision 265713)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+++ tools/llvm-ar/llvm-ar.cpp (working copy)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">@@ -760,7 +760,7 @@<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">static int ranlib_main() {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> if (RestOfArgs.size() != 1)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">- fail(ToolName + "takes just one archive as argument");<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+ fail(ToolName + " takes just one archive as an argument");<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> ArchiveName = RestOfArgs[0];<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> return performOperation(CreateSymTab, nullptr);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">}<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Douglas Yung<o:p></o:p></p>
</div>
</body>
</html>