<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 1, 2016 at 4:59 AM, George Rimar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: grimar<br>
Date: Fri Apr  1 06:59:32 2016<br>
New Revision: 265136<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=265136&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=265136&view=rev</a><br>
Log:<br>
Make dummySectionsNum() to be not a member of writer. NFC.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Writer.cpp<br>
<br>
Modified: lld/trunk/ELF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=265136&r1=265135&r2=265136&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=265136&r1=265135&r2=265136&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Writer.cpp (original)<br>
+++ lld/trunk/ELF/Writer.cpp Fri Apr  1 06:59:32 2016<br>
@@ -107,9 +107,6 @@ private:<br>
   unsigned getNumSections() const {<br>
     return OutputSections.size() + 1 - dummySectionsNum();<br>
   }<br>
-  // Usually there are 2 dummies sections: ELF header and program header.<br>
-  // Relocatable output does not require program headers to be created.<br>
-  unsigned dummySectionsNum() const { return Config->Relocatable ? 1 : 2; }<br>
<br>
   void addRelIpltSymbols();<br>
   void addStartEndSymbols();<br>
@@ -127,6 +124,10 @@ private:<br>
 };<br>
 } // anonymous namespace<br>
<br>
+// Usually there are 2 dummies sections: ELF header and program header.<br>
+// Relocatable output does not require program headers to be created.<br>
+unsigned dummySectionsNum() { return Config->Relocatable ? 1 : 2; }<br>
+<br></blockquote><div><br></div><div>This should probably be called getNumDummySections or something so that it complies with the coding standards: <a href="http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly">http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly</a></div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
 template <class ELFT> void elf::writeResult(SymbolTable<ELFT> *Symtab) {<br>
   typedef typename ELFT::uint uintX_t;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>