<div dir="ltr">Thanks Dave!</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 28, 2016 at 10:51 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Mon, Mar 28, 2016 at 4:50 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">On 25 March 2016 at 17:59, Lang Hames via llvm-commits<br>
<span><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: lhames<br>
> Date: Fri Mar 25 16:59:14 2016<br>
> New Revision: 264469<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264469&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=264469&view=rev</a><br>
> Log:<br>
> [Object] Make MachOObjectFile's constructor private, provide a static create<br>
> method instead.<br>
><br>
> This is not quite a named constructor: Construction may fail, and<br>
> MachOObjectFiles are usually passed by unique_ptr anyway, so create<br>
> returns an Expected<std::unique_ptr<MachOObjectFile>>.<br>
<br>
</span>This is awesome.<br>
<span><br>
> +  if (Magic == "\xFE\xED\xFA\xCE")<br>
> +    return expectedToErrorOr(<br>
> +        MachOObjectFile::create(Buffer, false, false));<br>
> +  else if (Magic == "\xCE\xFA\xED\xFE")<br>
> +    return expectedToErrorOr(<br>
> +        MachOObjectFile::create(Buffer, true, false));<br>
> +  else if (Magic == "\xFE\xED\xFA\xCF")<br>
> +    return expectedToErrorOr(<br>
> +        MachOObjectFile::create(Buffer, false, true));<br>
> +  else if (Magic == "\xCF\xFA\xED\xFE")<br>
> +    return expectedToErrorOr(<br>
> +        MachOObjectFile::create(Buffer, true, true));<br>
> +  //else<br>
> +  return object_error::parse_failed;<br>
<br>
</span>You don't need the "else if" now that the returns are unconditional.<br></blockquote><div><br></div></div></div><div>Good call - got that in r264599 (figured I'd pick up the slack since Lang's out of town for a bit)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Cheers,<br>
Rafael<span class=""><br>
<div><div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></span></blockquote></div><br></div></div>
</blockquote></div><br></div>