<div dir="ltr">What error did you get? I'm wondering why this works although StringRef didn't work.<div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 4, 2016 at 7:31 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Mon Apr  4 09:31:20 2016<br>
New Revision: 265297<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=265297&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=265297&view=rev</a><br>
Log:<br>
Try to fix the windows build.<br>
<br>
MSVC doesn't want StringRef in an union.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Symbols.h<br>
<br>
Modified: lld/trunk/ELF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=265297&r1=265296&r2=265297&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=265297&r1=265296&r2=265297&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Symbols.h (original)<br>
+++ lld/trunk/ELF/Symbols.h Mon Apr  4 09:31:20 2016<br>
@@ -77,7 +77,7 @@ public:<br>
   // Returns the symbol name.<br>
   StringRef getName() const {<br>
     assert(!isLocal());<br>
-    return Name;<br>
+    return StringRef(Name.S, Name.Len);<br>
   }<br>
   uint32_t getNameOffset() const {<br>
     assert(isLocal());<br>
@@ -127,7 +127,8 @@ protected:<br>
   SymbolBody(Kind K, StringRef Name, uint8_t Binding, uint8_t Other,<br>
              uint8_t Type)<br>
       : SymbolKind(K), MustBeInDynSym(false), NeedsCopyOrPltAddr(false),<br>
-        Type(Type), Binding(Binding), Other(Other), Name(Name) {<br>
+        Type(Type), Binding(Binding), Other(Other),<br>
+        Name({Name.data(), Name.size()}) {<br>
     assert(!isLocal());<br>
     IsUsedInRegularObj =<br>
         K != SharedKind && K != LazyKind && K != DefinedBitcodeKind;<br>
@@ -163,8 +164,12 @@ public:<br>
   void setVisibility(uint8_t V) { Other = (Other & ~0x3) | V; }<br>
<br>
 protected:<br>
+  struct Str {<br>
+    const char *S;<br>
+    size_t Len;<br>
+  };<br>
   union {<br>
-    StringRef Name;<br>
+    Str Name;<br>
     uint32_t NameOffset;<br>
   };<br>
   Symbol *Backref = nullptr;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>