<div dir="ltr">Does it accept --lto-O-1 as optimization level -1? If so, you want to take care of that as well.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Apr 2, 2016 at 7:41 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Sat Apr  2 21:41:15 2016<br>
New Revision: 265255<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=265255&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=265255&view=rev</a><br>
Log:<br>
[LTO] Reject invalid optimization levels.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Driver.cpp<br>
    lld/trunk/test/ELF/lto/opt-level.ll<br>
<br>
Modified: lld/trunk/ELF/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=265255&r1=265254&r2=265255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=265255&r1=265254&r2=265255&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Driver.cpp (original)<br>
+++ lld/trunk/ELF/Driver.cpp Sat Apr  2 21:41:15 2016<br>
@@ -301,6 +301,8 @@ void LinkerDriver::readConfigs(opt::Inpu<br>
<br>
   Config->Optimize = getInteger(Args, OPT_O, 0);<br>
   Config->LtoO = getInteger(Args, OPT_lto_O, 2);<br>
+  if (Config->LtoO > 3)<br>
+    error("invalid optimization level for LTO: " + getString(Args, OPT_lto_O));<br>
<br>
   Config->ZExecStack = hasZOption(Args, "execstack");<br>
   Config->ZNodelete = hasZOption(Args, "nodelete");<br>
<br>
Modified: lld/trunk/test/ELF/lto/opt-level.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/opt-level.ll?rev=265255&r1=265254&r2=265255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/opt-level.ll?rev=265255&r1=265254&r2=265255&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/lto/opt-level.ll (original)<br>
+++ lld/trunk/test/ELF/lto/opt-level.ll Sat Apr  2 21:41:15 2016<br>
@@ -6,6 +6,11 @@<br>
 ; RUN: ld.lld -o %t2a -m elf_x86_64 -e main %t.o<br>
 ; RUN: llvm-nm %t2a | FileCheck --check-prefix=CHECK-O2 %s<br>
<br>
+; Reject invalid optimization levels.<br>
+; RUN: not ld.lld -o %t3 -m elf_x86_64 -e main --lto-O6 %t.o 2>&1 | \<br>
+; RUN:   FileCheck --check-prefix=INVALID %s<br>
+; INVALID: invalid optimization level for LTO: 6<br>
+<br>
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br>
 target triple = "x86_64-unknown-linux-gnu"<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>