<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">r264615<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 28, 2016, at 11:38 AM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" class="">xinliangli@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">That is right. Thanks for catching this.<div class=""><br class=""></div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Mar 28, 2016 at 11:36 AM, Sean Silva via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I think this file has to use C-style /* */ comments.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Mar 28, 2016 at 11:29 AM, Adam Nemet via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: anemet<br class="">
Date: Mon Mar 28 13:29:36 2016<br class="">
New Revision: 264612<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264612&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=264612&view=rev</a><br class="">
Log:<br class="">
[PGO] Comment how function pointers for indirect calls are mapped to function names<br class="">
<br class="">
Summary:<br class="">
Hopefully this will make it easier for the next person to figure all<br class="">
this out...<br class="">
<br class="">
Reviewers: bogner, davidxl<br class="">
<br class="">
Subscribers: llvm-commits<br class="">
<br class="">
Differential Revision: <a href="http://reviews.llvm.org/D18490" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D18490</a><br class="">
<br class="">
Modified:<br class="">
compiler-rt/trunk/lib/profile/InstrProfData.inc<br class="">
<br class="">
Modified: compiler-rt/trunk/lib/profile/InstrProfData.inc<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfData.inc?rev=264612&r1=264611&r2=264612&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfData.inc?rev=264612&r1=264611&r2=264612&view=diff</a><br class="">
==============================================================================<br class="">
--- compiler-rt/trunk/lib/profile/InstrProfData.inc (original)<br class="">
+++ compiler-rt/trunk/lib/profile/InstrProfData.inc Mon Mar 28 13:29:36 2016<br class="">
@@ -73,6 +73,8 @@ INSTR_PROF_DATA(const uint64_t, llvm::Ty<br class="">
INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt64PtrTy(Ctx), CounterPtr, \<br class="">
ConstantExpr::getBitCast(CounterPtr, \<br class="">
llvm::Type::getInt64PtrTy(Ctx)))<br class="">
+// This is used to map function pointers for the indirect call targets to<br class="">
+// function name hashes during the conversion from raw to merged profile data.<br class="">
INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt8PtrTy(Ctx), FunctionPointer, \<br class="">
FunctionAddr)<br class="">
INSTR_PROF_DATA(IntPtrT, llvm::Type::getInt8PtrTy(Ctx), Values, \<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></div><br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>