<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">OK, good point, thanks. Will update.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 28, 2016, at 11:36 AM, Sean Silva <<a href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Mon, Mar 28, 2016 at 11:27 AM, Adam Nemet via llvm-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: anemet<br class="">Date: Mon Mar 28 13:27:44 2016<br class="">New Revision: 264611<br class=""><br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=264611&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=264611&view=rev</a><br class="">Log:<br class="">[PGO] Comment how function pointers for indirect calls are mapped to function names<br class=""><br class="">Summary:<br class="">Hopefully this will make it easier for the next person to figure all<br class="">this out...<br class=""><br class="">Reviewers: bogner, davidxl<br class=""><br class="">Subscribers: llvm-commits<br class=""><br class="">Differential Revision:<span class="Apple-converted-space"> </span><a href="http://reviews.llvm.org/D18490" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D18490</a><br class=""><br class="">Modified:<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/include/llvm/ProfileData/InstrProfData.inc<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/lib/ProfileData/InstrProfReader.cpp<br class=""><br class="">Modified: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfData.inc?rev=264611&r1=264610&r2=264611&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfData.inc?rev=264611&r1=264610&r2=264611&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/include/llvm/ProfileData/InstrProfData.inc (original)<br class="">+++ llvm/trunk/include/llvm/ProfileData/InstrProfData.inc Mon Mar 28 13:27:44 2016<br class="">@@ -73,6 +73,8 @@ INSTR_PROF_DATA(const uint64_t, llvm::Ty<br class=""> INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt64PtrTy(Ctx), CounterPtr, \<br class=""> ConstantExpr::getBitCast(CounterPtr, \<br class=""> llvm::Type::getInt64PtrTy(Ctx)))<br class="">+// This is used to map function pointers for the indirect call targets to<br class="">+// function name hashes during the conversion from raw to merged profile data.<br class=""></blockquote><div class=""><br class=""></div><div class=""><span style="font-size: 12.8px;" class="">I think this file has to use C-style /* */ comments.</span><br class=""></div><div class=""><span style="font-size: 12.8px;" class=""><br class=""></span></div><div class=""><span style="font-size: 12.8px;" class="">-- Sean Silva</span></div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"> INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt8PtrTy(Ctx), FunctionPointer, \<br class=""> FunctionAddr)<br class=""> INSTR_PROF_DATA(IntPtrT, llvm::Type::getInt8PtrTy(Ctx), Values, \<br class=""><br class="">Modified: llvm/trunk/lib/ProfileData/InstrProfReader.cpp<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/InstrProfReader.cpp?rev=264611&r1=264610&r2=264611&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/InstrProfReader.cpp?rev=264611&r1=264610&r2=264611&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/ProfileData/InstrProfReader.cpp (original)<br class="">+++ llvm/trunk/lib/ProfileData/InstrProfReader.cpp Mon Mar 28 13:27:44 2016<br class="">@@ -412,6 +412,9 @@ RawInstrProfReader<IntPtrT>::readValuePr<br class=""> if (VDataPtrOrErr.getError())<br class=""> return VDataPtrOrErr.getError();<br class=""><br class="">+ // Note that besides deserialization, this also performs the conversion for<br class="">+ // indirect call targets. The function pointers from the raw profile are<br class="">+ // remapped into function name hashes.<br class=""> VDataPtrOrErr.get()->deserializeTo(Record, &Symtab->getAddrHashMap());<br class=""> CurValueDataSize = VDataPtrOrErr.get()->getSize();<br class=""> return success();<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></div></body></html>