<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 25, 2016, at 8:29 AM, Mehdi Amini via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Here is one: <a href="http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/17076/steps/build%20stage%201/logs/stdio" class="">http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/17076/steps/build%20stage%201/logs/stdio</a></div><div class="">I haven't had time to understand why gcc would resolve differently than clang. </div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Also it seems MSVC is doing more move than expected: <a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10868/steps/ninja%20check%202/logs/stdio" class="">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10868/steps/ninja%20check%202/logs/stdio</a></div><div class="">I feel this is gonna be challenging at I don't have a windows to reproduce...</div></div></div></blockquote><div><br class=""></div><div>I think the test is relying on move-construction elision, I disabled the move part of the test for now. Do you have a suggestion?</div><div><br class=""></div><div>-- </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">--</div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 25, 2016, at 7:43 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">Got a link to the failure?</p>
<div class="gmail_quote">On Mar 25, 2016 7:19 AM, "Mehdi Amini" <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class=""><div class="">Build failure on gcc bots. Not sure how to test?<br class=""><br class="">Sent from my iPhone</div><div class=""><br class="">On Mar 25, 2016, at 7:09 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank" class="">dblaikie@gmail.com</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class=""><p dir="ltr" class="">Test case?</p>
<div class="gmail_quote">On Mar 25, 2016 12:16 AM, "Mehdi Amini via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="">
Date: Fri Mar 25 02:11:31 2016<br class="">
New Revision: 264391<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264391&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=264391&view=rev</a><br class="">
Log:<br class="">
Fix perfect forwarding for StringMap<br class="">
<br class="">
From: Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>><br class="">
<br class="">
Modified:<br class="">
    llvm/trunk/include/llvm/ADT/StringMap.h<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/ADT/StringMap.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringMap.h?rev=264391&r1=264390&r2=264391&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringMap.h?rev=264391&r1=264390&r2=264391&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/ADT/StringMap.h (original)<br class="">
+++ llvm/trunk/include/llvm/ADT/StringMap.h Fri Mar 25 02:11:31 2016<br class="">
@@ -123,9 +123,9 @@ public:<br class="">
<br class="">
   explicit StringMapEntry(unsigned strLen)<br class="">
     : StringMapEntryBase(strLen), second() {}<br class="">
-  template <class InitTy><br class="">
-  StringMapEntry(unsigned strLen, InitTy &&V)<br class="">
-      : StringMapEntryBase(strLen), second(std::forward<InitTy>(V)) {}<br class="">
+  template <typename... InitTy><br class="">
+  StringMapEntry(unsigned strLen, InitTy &&... InitVals)<br class="">
+      : StringMapEntryBase(strLen), second(std::forward<InitTy>(InitVals)...) {}<br class="">
<br class="">
   StringRef getKey() const {<br class="">
     return StringRef(getKeyData(), getKeyLength());<br class="">
@@ -145,9 +145,9 @@ public:<br class="">
<br class="">
   /// Create a StringMapEntry for the specified key construct the value using<br class="">
   /// \p InitiVals.<br class="">
-  template <typename AllocatorTy, typename... InitTypes><br class="">
+  template <typename AllocatorTy, typename... InitTy><br class="">
   static StringMapEntry *Create(StringRef Key, AllocatorTy &Allocator,<br class="">
-                                InitTypes &&... InitVals) {<br class="">
+                                InitTy &&... InitVals) {<br class="">
     unsigned KeyLength = Key.size();<br class="">
<br class="">
     // Allocate a new item with space for the string at the end and a null<br class="">
@@ -160,8 +160,7 @@ public:<br class="">
       static_cast<StringMapEntry*>(Allocator.Allocate(AllocSize,Alignment));<br class="">
<br class="">
     // Construct the value.<br class="">
-    new (NewItem)<br class="">
-        StringMapEntry(KeyLength, std::forward<InitTypes>(InitVals)...);<br class="">
+    new (NewItem) StringMapEntry(KeyLength, std::forward<InitTy>(InitVals)...);<br class="">
<br class="">
     // Copy the string information.<br class="">
     char *StrBuffer = const_cast<char*>(NewItem->getKeyData());<br class="">
@@ -172,10 +171,10 @@ public:<br class="">
   }<br class="">
<br class="">
   /// Create - Create a StringMapEntry with normal malloc/free.<br class="">
-  template<typename InitType><br class="">
-  static StringMapEntry *Create(StringRef Key, InitType &&InitVal) {<br class="">
+  template <typename... InitType><br class="">
+  static StringMapEntry *Create(StringRef Key, InitType &&... InitVal) {<br class="">
     MallocAllocator A;<br class="">
-    return Create(Key, A, std::forward<InitType>(InitVal));<br class="">
+    return Create(Key, A, std::forward<InitType>(InitVal)...);<br class="">
   }<br class="">
<br class="">
   static StringMapEntry *Create(StringRef Key) {<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div></blockquote></div>
</div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>