<div dir="ltr">Could/should we be using a standard trait (std::is_trivially_copyable)?</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 25, 2016 at 3:00 PM, JF Bastien via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jfb created this revision.<br>
jfb added a subscriber: llvm-commits.<br>
<br>
isPodLike is as close as we have for is_trivially_copyable.<br>
<br>
<a href="http://reviews.llvm.org/D18483" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18483</a><br>
<br>
Files:<br>
  lib/CodeGen/MachineInstr.cpp<br>
<br>
Index: lib/CodeGen/MachineInstr.cpp<br>
===================================================================<br>
--- lib/CodeGen/MachineInstr.cpp<br>
+++ lib/CodeGen/MachineInstr.cpp<br>
@@ -38,6 +38,7 @@<br>
 #include "llvm/Support/ErrorHandling.h"<br>
 #include "llvm/Support/MathExtras.h"<br>
 #include "llvm/Support/raw_ostream.h"<br>
+#include "llvm/Support/type_traits.h"<br>
 #include "llvm/Target/TargetInstrInfo.h"<br>
 #include "llvm/Target/TargetMachine.h"<br>
 #include "llvm/Target/TargetRegisterInfo.h"<br>
@@ -757,7 +758,8 @@<br>
   if (MRI)<br>
     return MRI->moveOperands(Dst, Src, NumOps);<br>
<br>
-  // MachineOperand is a trivially copyable type so we can just use memmove.<br>
+  static_assert(isPodLike<MachineOperand>::value,<br>
+                "must be trivially copyable to memmove");<br>
   std::memmove(Dst, Src, NumOps * sizeof(MachineOperand));<br>
 }<br>
<br>
<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>