<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Mar 23, 2016 at 7:41 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: davide<br>
Date: Wed Mar 23 13:41:48 2016<br>
New Revision: 264181<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264181&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=264181&view=rev</a><br>
Log:<br>
[LTO] Keep linkonce symbols when required.<br>
<br>
Similarly to how we do with linkonce_odr symbols already, but<br>
change their linkage to weak.<br>
<br>
Added:<br>
    lld/trunk/test/ELF/lto/Inputs/linkonce.ll<br>
    lld/trunk/test/ELF/lto/linkonce.ll<br>
Modified:<br>
    lld/trunk/ELF/LTO.cpp<br>
<br>
Modified: lld/trunk/ELF/LTO.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LTO.cpp?rev=264181&r1=264180&r2=264181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LTO.cpp?rev=264181&r1=264180&r2=264181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/LTO.cpp (original)<br>
+++ lld/trunk/ELF/LTO.cpp Wed Mar 23 13:41:48 2016<br>
@@ -85,8 +85,16 @@ void BitcodeCompiler::add(BitcodeFile &F<br>
     if (!BitcodeFile::shouldSkip(Sym)) {<br>
       if (SymbolBody *B = Bodies[BodyIndex++])<br>
         if (&B->repl() == B && isa<DefinedBitcode>(B)) {<br>
-          if (GV->getLinkage() == llvm::GlobalValue::LinkOnceODRLinkage)<br>
+          switch (GV->getLinkage()) {<br>
+          default:<br>
+            break;<br>
+          case llvm::GlobalValue::LinkOnceAnyLinkage:<br>
+            GV->setLinkage(GlobalValue::WeakAnyLinkage);<br>
+            break;<br>
+          case llvm::GlobalValue::LinkOnceODRLinkage:<br>
             GV->setLinkage(GlobalValue::WeakODRLinkage);<br>
+            break;<br>
+          }<br>
           Keep.push_back(GV);<br></blockquote><div><br></div><div>Can you reduce the indentation? I think you can do this.</div><div><br></div><div><div>    if (BitcodeFile::shouldSkip(Sym))</div><div>      continue;</div><div>    SymbolBody *B = Bodies[BodyIndex++];</div><div>    if (!B || &B->repl() != B || !isa<DefinedBitcode>(B))</div><div>      continue;</div><div>    switch (GV-getLinkage()) {</div><div>      ...</div><div>    }</div><div>    Keep.push_back(GV);</div><div> <br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">         }<br>
     }<br>
<br>
Added: lld/trunk/test/ELF/lto/Inputs/linkonce.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/Inputs/linkonce.ll?rev=264181&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/Inputs/linkonce.ll?rev=264181&view=auto</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/lto/Inputs/linkonce.ll (added)<br>
+++ lld/trunk/test/ELF/lto/Inputs/linkonce.ll Wed Mar 23 13:41:48 2016<br>
@@ -0,0 +1,6 @@<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+<br>
+define linkonce void @f() {<br>
+  ret void<br>
+}<br>
<br>
Added: lld/trunk/test/ELF/lto/linkonce.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/linkonce.ll?rev=264181&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/linkonce.ll?rev=264181&view=auto</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/lto/linkonce.ll (added)<br>
+++ lld/trunk/test/ELF/lto/linkonce.ll Wed Mar 23 13:41:48 2016<br>
@@ -0,0 +1,17 @@<br>
+; REQUIRES: x86<br>
+; RUN: llvm-as %p/Inputs/linkonce.ll -o %t1.o<br>
+; RUN: llc %s -o %t2.o -filetype=obj<br>
+; RUN: ld.lld %t1.o %t2.o -o %t.so -shared -save-temps<br>
+; RUN: llvm-dis %t.so.lto.opt.bc -o - | FileCheck %s<br>
+<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+declare void @f()<br>
+<br>
+define void @g() {<br>
+  call void @f()<br>
+  ret void<br>
+}<br>
+<br>
+; Be sure that 'f' is kept and has weak linkage.<br>
+; CHECK: define weak void @f()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>