<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Turns out I needed per-segment tracking for my work, so I implemented it in r264240. (I don't think these numbers are recorded by lnt yet though)</div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 1, 2016, at 12:30 PM, Sean Silva <<a href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 1, 2016 at 12:00 PM, Matthias Braun <span dir="ltr" class=""><<a href="mailto:matze@braunis.de" target="_blank" class="">matze@braunis.de</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">patches welcome (sorry I couldn't resist).</div><div class=""><br class=""></div><div class="">This commit was meant to demonstrate how additional metrics can be collected and that the infrastructure is there.</div></div></blockquote><div class=""><br class=""></div><div class="">That it did! The fact that I was inspired to want to plug in llvm-size shows that you did a good job :)</div><div class=""><br class=""></div><div class="">-- Sean Silva</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""> I hope that fine grained metrics will be added over time. I have no plans myself yet at the moment to figure out what metrics are actually useful, testing it on different targets making sure we don't fail when llvm-size is not in the PATH...</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">- Matthias</div></font></span><div class=""><div class="h5"><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class="">On Mar 1, 2016, at 11:47 AM, Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Do you have llvm-size available? You could get some more fine-grained text/data/etc. information which might be more useful to track.<div class=""><br class=""></div><div class="">-- Sean Silva</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Feb 29, 2016 at 10:05 PM, Matthias Braun via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: matze<br class="">
Date: Tue Mar  1 00:05:27 2016<br class="">
New Revision: 262306<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262306&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=262306&view=rev</a><br class="">
Log:<br class="">
lit: Add simple codesize module<br class="">
<br class="">
This simply records the filesize of the executable.<br class="">
<br class="">
Added:<br class="">
    test-suite/trunk/litsupport/codesize.py<br class="">
Modified:<br class="">
    test-suite/trunk/litsupport/test.py<br class="">
<br class="">
Added: test-suite/trunk/litsupport/codesize.py<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/codesize.py?rev=262306&view=auto" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/codesize.py?rev=262306&view=auto</a><br class="">
==============================================================================<br class="">
--- test-suite/trunk/litsupport/codesize.py (added)<br class="">
+++ test-suite/trunk/litsupport/codesize.py Tue Mar  1 00:05:27 2016<br class="">
@@ -0,0 +1,13 @@<br class="">
+import lit.Test<br class="">
+import logging<br class="">
+import shellcommand<br class="">
+import os.path<br class="">
+<br class="">
+<br class="">
+def collect(context, result):<br class="">
+    try:<br class="">
+        size = os.path.getsize(context.executable)<br class="">
+        result.addMetric('size', lit.Test.toMetricValue(size))<br class="">
+    except:<br class="">
+        <a href="http://logging.info/" rel="noreferrer" target="_blank" class="">logging.info</a>('Could not calculate filesize for %s' %<br class="">
+                     context.executable)<br class="">
<br class="">
Modified: test-suite/trunk/litsupport/test.py<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=262306&r1=262305&r2=262306&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=262306&r1=262305&r2=262306&view=diff</a><br class="">
==============================================================================<br class="">
--- test-suite/trunk/litsupport/test.py (original)<br class="">
+++ test-suite/trunk/litsupport/test.py Tue Mar  1 00:05:27 2016<br class="">
@@ -8,6 +8,7 @@ from lit.TestRunner import executeScript<br class="">
 from lit import Test<br class="">
 from lit.util import to_bytes, to_string<br class="">
<br class="">
+import codesize<br class="">
 import compiletime<br class="">
 import hash<br class="">
 import perf<br class="">
@@ -151,5 +152,6 @@ class TestSuiteTest(FileBasedTest):<br class="">
             result.addMetric(metric, lit.Test.toMetricValue(values[0]))<br class="">
         compiletime.collect(context, result)<br class="">
         hash.collect(context, result)<br class="">
+        codesize.collect(context, result)<br class="">
<br class="">
         return result<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>