<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 23, 2016 at 8:45 PM, Matthias Braun <span dir="ltr"><<a href="mailto:matze@braunis.de" target="_blank">matze@braunis.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Turns out I needed per-segment tracking for my work, so I implemented it in r264240. (I don't think these numbers are recorded by lnt yet though)</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>- Matthias</div></font></span><div><div class="h5"><br><div><blockquote type="cite"><div>On Mar 1, 2016, at 12:30 PM, Sean Silva <<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 1, 2016 at 12:00 PM, Matthias Braun <span dir="ltr"><<a href="mailto:matze@braunis.de" target="_blank">matze@braunis.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>patches welcome (sorry I couldn't resist).</div><div><br></div><div>This commit was meant to demonstrate how additional metrics can be collected and that the infrastructure is there.</div></div></blockquote><div><br></div><div>That it did! The fact that I was inspired to want to plug in llvm-size shows that you did a good job :)</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div> I hope that fine grained metrics will be added over time. I have no plans myself yet at the moment to figure out what metrics are actually useful, testing it on different targets making sure we don't fail when llvm-size is not in the PATH...</div><span><font color="#888888"><div><br></div><div>- Matthias</div></font></span><div><div><div><br></div><div><blockquote type="cite"><div>On Mar 1, 2016, at 11:47 AM, Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr">Do you have llvm-size available? You could get some more fine-grained text/data/etc. information which might be more useful to track.<div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 29, 2016 at 10:05 PM, Matthias Braun via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: matze<br>
Date: Tue Mar 1 00:05:27 2016<br>
New Revision: 262306<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262306&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262306&view=rev</a><br>
Log:<br>
lit: Add simple codesize module<br>
<br>
This simply records the filesize of the executable.<br>
<br>
Added:<br>
test-suite/trunk/litsupport/codesize.py<br>
Modified:<br>
test-suite/trunk/litsupport/test.py<br>
<br>
Added: test-suite/trunk/litsupport/codesize.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/codesize.py?rev=262306&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/codesize.py?rev=262306&view=auto</a><br>
==============================================================================<br>
--- test-suite/trunk/litsupport/codesize.py (added)<br>
+++ test-suite/trunk/litsupport/codesize.py Tue Mar 1 00:05:27 2016<br>
@@ -0,0 +1,13 @@<br>
+import lit.Test<br>
+import logging<br>
+import shellcommand<br>
+import os.path<br>
+<br>
+<br>
+def collect(context, result):<br>
+ try:<br>
+ size = os.path.getsize(context.executable)<br>
+ result.addMetric('size', lit.Test.toMetricValue(size))<br>
+ except:<br>
+ <a href="http://logging.info/" rel="noreferrer" target="_blank">logging.info</a>('Could not calculate filesize for %s' %<br>
+ context.executable)<br>
<br>
Modified: test-suite/trunk/litsupport/test.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=262306&r1=262305&r2=262306&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=262306&r1=262305&r2=262306&view=diff</a><br>
==============================================================================<br>
--- test-suite/trunk/litsupport/test.py (original)<br>
+++ test-suite/trunk/litsupport/test.py Tue Mar 1 00:05:27 2016<br>
@@ -8,6 +8,7 @@ from lit.TestRunner import executeScript<br>
from lit import Test<br>
from lit.util import to_bytes, to_string<br>
<br>
+import codesize<br>
import compiletime<br>
import hash<br>
import perf<br>
@@ -151,5 +152,6 @@ class TestSuiteTest(FileBasedTest):<br>
result.addMetric(metric, lit.Test.toMetricValue(values[0]))<br>
compiletime.collect(context, result)<br>
hash.collect(context, result)<br>
+ codesize.collect(context, result)<br>
<br>
return result<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>
</div></blockquote></div><br></div></div></div></blockquote></div><br></div>