<div dir="ltr">I don't know the context very well. If this is not urgent, I'd like to wait for Dmitry Vyukov to make a decision. Personally,<div>I prefer to change the "// CHECK-NOT: WARNING" in cond_cancel.c into "// CHECK-NOT: WARNING: ThreadSanitizer:"</div><div>as other test files.<br><div><br></div><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 22, 2016 at 2:12 PM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Yabin,<br>
<br>
The tests are still broken:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/6892" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/6892</a><br>
<span class=""><br>
WARNING: Program is run with randomized virtual address space, which<br>
wouldn't work with ThreadSanitizer.<br>
<br>
</span>Should we just revert the changes until this is discussed further?<br>
<br>
cheers,<br>
--renato<br>
<br>
On 22 March 2016 at 18:12, Yabin Cui via llvm-commits<br>
<div class=""><div class="h5"><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: yabinc<br>
> Date: Tue Mar 22 13:12:18 2016<br>
> New Revision: 264079<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=264079&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=264079&view=rev</a><br>
> Log:<br>
> [tsan] Fix check-tsan build by using CHECK_NE.<br>
><br>
> Reviewers: llvm-commits, srhines, dvyukov<br>
><br>
> Subscribers: srhines<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D18361" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18361</a><br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc?rev=264079&r1=264078&r2=264079&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc?rev=264079&r1=264078&r2=264079&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc (original)<br>
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc Tue Mar 22 13:12:18 2016<br>
> @@ -302,7 +302,7 @@ void InitializePlatform() {<br>
>        Report("WARNING: Program is run with randomized virtual address space,"<br>
>               " which wouldn't work with ThreadSanitizer.\n");<br>
>        Report("Re-execing with fixed virtual address space.\n");<br>
> -      CHECK(personality(old_personality | ADDR_NO_RANDOMIZE) != -1);<br>
> +      CHECK_NE(-1, personality(old_personality | ADDR_NO_RANDOMIZE));<br>
>        reexec = true;<br>
>      }<br>
>  #endif<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div></div></div>