<div dir="ltr">Thanks! <div>Just curious, in where you were building libFuzzer with GCC? </div><div>In the LLVM cmake the libFuzzer build is guarded by -DLLVM_USE_SANITIZE_COVERAGE=YES which only works with clang. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 18, 2016 at 7:19 AM, Benjamin Kramer via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Mar 18 09:19:19 2016<br>
New Revision: 263787<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=263787&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=263787&view=rev</a><br>
Log:<br>
[Fuzzer] Guard no_sanitize_memory attributes behind __has_feature.<br>
<br>
Otherwise GCC fails to build it because it doesn't know the attribute.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp<br>
<br>
Modified: llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp?rev=263787&r1=263786&r2=263787&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp?rev=263787&r1=263786&r2=263787&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp (original)<br>
+++ llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp Fri Mar 18 09:19:19 2016<br>
@@ -20,6 +20,14 @@<br>
 #endif<br>
 #endif<br>
<br>
+#define NO_SANITIZE_MEMORY<br>
+#if defined(__has_feature)<br>
+#if __has_feature(memory_sanitizer)<br>
+#undef NO_SANITIZE_MEMORY<br>
+#define NO_SANITIZE_MEMORY __attribute__((no_sanitize_memory))<br>
+#endif<br>
+#endif<br>
+<br>
 extern "C" {<br>
 // Re-declare some of the sanitizer functions as "weak" so that<br>
 // libFuzzer can be linked w/o the sanitizers and sanitizer-coverage<br>
@@ -92,7 +100,7 @@ void Fuzzer::DumpCurrentUnit(const char<br>
       {CurrentUnitData, CurrentUnitData + CurrentUnitSize}, Prefix);<br>
 }<br>
<br>
-__attribute__((no_sanitize_memory))<br>
+NO_SANITIZE_MEMORY<br>
 void Fuzzer::DeathCallback() {<br>
   if (!CurrentUnitSize) return;<br>
   Printf("DEATH:\n");<br>
@@ -134,7 +142,7 @@ void Fuzzer::InterruptCallback() {<br>
   _Exit(0);  // Stop right now, don't perform any at-exit actions.<br>
 }<br>
<br>
-__attribute__((no_sanitize_memory))<br>
+NO_SANITIZE_MEMORY<br>
 void Fuzzer::AlarmCallback() {<br>
   assert(Options.UnitTimeoutSec > 0);<br>
   if (!CurrentUnitSize)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>