<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">r263869.<div class=""><br class=""></div><div class="">Thanks for the suggestion.</div><div class=""><br class=""></div><div class="">-- </div><div class="">Mehdi</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 18, 2016, at 6:07 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Might be worth leaving a comment trail in each of these to explain why only some fields are being hashed?</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Mar 18, 2016 at 5:59 PM, Mehdi Amini via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="">
Date: Fri Mar 18 19:59:26 2016<br class="">
New Revision: 263866<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=263866&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=263866&view=rev</a><br class="">
Log:<br class="">
Compute some Debug Info Metadata hash key partially (NFC)<br class="">
<br class="">
Summary:<br class="">
This patch changes the computation of the hash key for DISubprogram to<br class="">
be computed on a small subset of the fields. The hash is computed a<br class="">
lot faster, but there might be more collision in the table.<br class="">
However by carefully selecting the fields, colisions should be rare.<br class="">
<br class="">
Using `opt` to load the IR for FastISelEmitter.cpp.o, with this patch:<br class="">
- DISubprogram::getImpl() goes from 28ms to 15ms.<br class="">
- DICompositeType::getImpl() goes from 6ms to 2ms<br class="">
- DIDerivedType::getImpl() goes from 18 to 12ms<br class="">
<br class="">
Reviewers: dexonsmith<br class="">
<br class="">
Subscribers: llvm-commits<br class="">
<br class="">
Differential Revision: <a href="http://reviews.llvm.org/D16571" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D16571</a><br class="">
<br class="">
From: Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/IR/LLVMContextImpl.h<br class="">
<br class="">
Modified: llvm/trunk/lib/IR/LLVMContextImpl.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.h?rev=263866&r1=263865&r2=263866&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.h?rev=263866&r1=263865&r2=263866&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/IR/LLVMContextImpl.h (original)<br class="">
+++ llvm/trunk/lib/IR/LLVMContextImpl.h Fri Mar 18 19:59:26 2016<br class="">
@@ -365,8 +365,7 @@ template <> struct MDNodeKeyImpl<DIDeriv<br class="">
ExtraData == RHS->getRawExtraData();<br class="">
}<br class="">
unsigned getHashValue() const {<br class="">
- return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br class="">
- AlignInBits, OffsetInBits, Flags, ExtraData);<br class="">
+ return hash_combine(Tag, Name, File, Line, Scope, BaseType, Flags);<br class="">
}<br class="">
};<br class="">
<br class="">
@@ -422,9 +421,8 @@ template <> struct MDNodeKeyImpl<DICompo<br class="">
Identifier == RHS->getIdentifier();<br class="">
}<br class="">
unsigned getHashValue() const {<br class="">
- return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br class="">
- AlignInBits, OffsetInBits, Flags, Elements, RuntimeLang,<br class="">
- VTableHolder, TemplateParams, Identifier);<br class="">
+ return hash_combine(Name, File, Line, BaseType, Scope, Elements,<br class="">
+ TemplateParams);<br class="">
}<br class="">
};<br class="">
<br class="">
@@ -518,10 +516,7 @@ template <> struct MDNodeKeyImpl<DISubpr<br class="">
Variables == RHS->getRawVariables();<br class="">
}<br class="">
unsigned getHashValue() const {<br class="">
- return hash_combine(Scope, Name, LinkageName, File, Line, Type,<br class="">
- IsLocalToUnit, IsDefinition, ScopeLine, ContainingType,<br class="">
- Virtuality, VirtualIndex, Flags, IsOptimized,<br class="">
- TemplateParams, Declaration, Variables);<br class="">
+ return hash_combine(Name, Scope, File, Type, Line);<br class="">
}<br class="">
};<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>