<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks. <span style="font-family: 'Helvetica Neue';" class="">r263676/</span><span style="font-family: 'Helvetica Neue';" class="">r263677.</span><div class=""><font face="Helvetica Neue" class=""><br class=""></font><div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">Tomorrow I'm going to go and pick Nick's brain about the intended memory model for lld - we should either properly delete atoms, or document the policy that anything they contain be allocated on the same allocator.</div></div></div></blockquote>Yeah. I’ll say that i’m fine with the current model of leaking atoms in an allocator, but it should be documented.</div><div><br class=""></div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">- Lang. </div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Mar 16, 2016 at 3:57 PM, Pete Cooper via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping. @Lang, does this look ok?<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
Pete<br class="">
</font></span><div class="HOEnZb"><div class="h5">> On Feb 4, 2016, at 4:57 PM, Pete Cooper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Thanks for pinging this. I’d forgotten about it.<br class="">
><br class="">
> Spoke to Nick in person. He said he was happy to defer to Lang on this one.<br class="">
><br class="">
> And thanks for your LGTM. Assuming Lang is ok with it i’ll commit it.<br class="">
><br class="">
> Cheers,<br class="">
> Pete<br class="">
>> On Feb 4, 2016, at 4:53 PM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:<br class="">
>><br class="">
>> Nick, any thought on this? It would be awesome to have check-lld asan clean.<br class="">
>><br class="">
>> The patch looks good to me in that all that I see is an allocator<br class="">
>> being passed to more places, but I don't know if that was the<br class="">
>> intention.<br class="">
>><br class="">
>> Cheers,<br class="">
>> Rafael<br class="">
>><br class="">
>><br class="">
>> On 26 January 2016 at 10:42, Rafael Espíndola<br class="">
>> <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:<br class="">
>>> Nick is probably the best reviewer for the yaml code.<br class="">
>>><br class="">
>>> Cheers,<br class="">
>>> Rafael<br class="">
>>><br class="">
>>><br class="">
>>> On 25 January 2016 at 12:34, Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:<br class="">
>>>> Hi Rafael<br class="">
>>>><br class="">
>>>> This should fix some of the leaks seen in PR 21466.<br class="">
>>>><br class="">
>>>> The cause was the MappingNormalizationHeap struct which was allocating atoms. In the binary file parser we allocate atoms in the file::allocator() so that we can avoid the free cost later.<br class="">
>>>><br class="">
>>>> This patch makes atoms use the file allocator in the YAML parser when needed.<br class="">
>>>><br class="">
>>>> Note, this doesn’t fix all the leaks. There’s still a bunch I’m trying to understand, but its a good start.<br class="">
>>>><br class="">
>>>> Thanks<br class="">
>>>> Pete<br class="">
>>>><br class="">
><br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>