<p dir="ltr">Yeah. Fix incoming. </p>
<br><div class="gmail_quote"><div dir="ltr">On Mon, Mar 14, 2016, 7:33 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 14, 2016 at 7:19 PM, Eric Christopher via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Mon Mar 14 21:19:06 2016<br>
New Revision: 263525<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=263525&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=263525&view=rev</a><br>
Log:<br>
Fix llvm/llvm/lib/Transforms/Utils/LoopUnroll.cpp:285:53: error: suggest<br>
parentheses around '&&' within '||' [-Werror=parentheses].<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp?rev=263525&r1=263524&r2=263525&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp?rev=263525&r1=263524&r2=263525&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp Mon Mar 14 21:19:06 2016<br>
@@ -275,17 +275,15 @@ bool llvm::UnrollLoop(Loop *L, unsigned<br>
<br>
   // Loops containing convergent instructions must have a count that divides<br>
   // their TripMultiple.<br>
-  DEBUG(<br>
-    bool HasConvergent = false;<br>
-    for (auto &BB : L->blocks())<br>
-      for (auto &I : *BB)<br>
-        if (auto CS = CallSite(&I))<br>
-          HasConvergent |= CS.isConvergent();<br>
-    assert(<br>
-        !HasConvergent || TripMultiple % Count == 0 &&<br>
-        "Unroll count must divide trip multiple if loop contains a convergent "<br>
-        "operation.");<br>
-  );<br>
+  DEBUG(bool HasConvergent = false;<br>
+        for (auto &BB<br>
+             : L->blocks()) for (auto &I<br>
+                                 : *BB) if (auto CS = CallSite(&I))<br></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>That's ^ some weird indentation.</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+            HasConvergent |= CS.isConvergent();<br>
+        assert((!HasConvergent || TripMultiple % Count == 0) &&<br>
+               "Unroll count must divide trip multiple if loop contains a "<br>
+               "convergent "<br>
+               "operation."););<br>
   // Don't output the runtime loop prolog if Count is a multiple of<br>
   // TripMultiple.  Such a prolog is never needed, and is unsafe if the loop<br>
   // contains a convergent instruction.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></blockquote></div>