<div dir="ltr">Wow, nice!</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 11, 2016 at 11:25 AM Benjamin Kramer via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Mar 11 04:20:56 2016<br>
New Revision: 263215<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=263215&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=263215&view=rev</a><br>
Log:<br>
[InstCombine] Use Twines to generate names.<br>
<br>
Since the names are used in a loop this does more work in debug builds. In<br>
release builds value names are generally discarded so we don't have to do<br>
the concatenation at all. It's also simpler code, no functional change<br>
intended.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp?rev=263215&r1=263214&r2=263215&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp?rev=263215&r1=263214&r2=263215&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp Fri Mar 11 04:20:56 2016<br>
@@ -523,7 +523,7 @@ static Instruction *unpackLoadToAggregat<br>
   if (!T->isAggregateType())<br>
     return nullptr;<br>
<br>
-  auto Name = LI.getName();<br>
+  StringRef Name = LI.getName();<br>
   assert(LI.getAlignment() && "Alignment must be set at this point");<br>
<br>
   if (auto *ST = dyn_cast<StructType>(T)) {<br>
@@ -547,11 +547,6 @@ static Instruction *unpackLoadToAggregat<br>
     if (!Align)<br>
       Align = DL.getABITypeAlignment(ST);<br>
<br>
-    SmallString<16> LoadName = Name;<br>
-    LoadName += ".unpack";<br>
-    SmallString<16> EltName = Name;<br>
-    EltName += ".elt";<br>
-<br>
     auto *Addr = LI.getPointerOperand();<br>
     auto *IdxType = Type::getInt32Ty(T->getContext());<br>
     auto *Zero = ConstantInt::get(IdxType, 0);<br>
@@ -563,9 +558,9 @@ static Instruction *unpackLoadToAggregat<br>
         ConstantInt::get(IdxType, i),<br>
       };<br>
       auto *Ptr = IC.Builder->CreateInBoundsGEP(ST, Addr, makeArrayRef(Indices),<br>
-                                                EltName);<br>
+                                                Name + ".elt");<br>
       auto EltAlign = MinAlign(Align, SL->getElementOffset(i));<br>
-      auto *L = IC.Builder->CreateAlignedLoad(Ptr, EltAlign, LoadName);<br>
+      auto *L = IC.Builder->CreateAlignedLoad(Ptr, EltAlign, Name + ".unpack");<br>
       V = IC.Builder->CreateInsertValue(V, L, i);<br>
     }<br>
<br>
@@ -588,11 +583,6 @@ static Instruction *unpackLoadToAggregat<br>
     if (!Align)<br>
       Align = DL.getABITypeAlignment(T);<br>
<br>
-    SmallString<16> LoadName = Name;<br>
-    LoadName += ".unpack";<br>
-    SmallString<16> EltName = Name;<br>
-    EltName += ".elt";<br>
-<br>
     auto *Addr = LI.getPointerOperand();<br>
     auto *IdxType = Type::getInt64Ty(T->getContext());<br>
     auto *Zero = ConstantInt::get(IdxType, 0);<br>
@@ -605,9 +595,9 @@ static Instruction *unpackLoadToAggregat<br>
         ConstantInt::get(IdxType, i),<br>
       };<br>
       auto *Ptr = IC.Builder->CreateInBoundsGEP(AT, Addr, makeArrayRef(Indices),<br>
-                                                EltName);<br>
+                                                Name + ".elt");<br>
       auto *L = IC.Builder->CreateAlignedLoad(Ptr, MinAlign(Align, Offset),<br>
-                                              LoadName);<br>
+                                              Name + ".unpack");<br>
       V = IC.Builder->CreateInsertValue(V, L, i);<br>
       Offset += EltSize;<br>
     }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>