<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks again! Responses inline.<br class=""><div><blockquote type="cite" class=""><div class="">On Mar 8, 2016, at 5:08 AM, Ying Yi <<a href="mailto:maggieyi666@gmail.com" class="">maggieyi666@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Thanks for adding the index page. I have some comments:</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">1) The ‘</span><span style="font-size: 10pt; background-image: none; background-attachment: scroll; background-color: white; background-position: 0% 0%; background-repeat: repeat repeat;" class="">unistd.h</span><span style="font-size: 10pt;" class="">’</span><span style="font-size: 10pt;" class=""><span class="Apple-converted-space"> </span>header won’t build on windows.</span></p><div class=""><br class=""></div></div></div></blockquote>Thanks for catching that — I was using it to debug, but don’t need it. I also don’t have a Windows machine to debug, so thank you for investigating portability!<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">2) The help text for ‘-format’ is different from llvm-profdata.exe tool, which uses the following style:</span></p><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class=""><span class=""> <span class="Apple-converted-space"> </span></span>-format=<html|console><span class=""> <span class="Apple-converted-space"> </span></span><span class=""> </span>- Format to output comparison ….</span></p><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class=""><span class=""> <span class="Apple-converted-space"> </span></span>Is there a standard way to do this?</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div></div></div></blockquote>LLVM’s CommandLine library renders the help text. Also, I noticed I used ‘comparison’ instead of ‘coverage’. Thanks!<br class=""><blockquote type="cite" class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">3)<span class="Apple-converted-space"> </span></span><span style="font-size: 10pt;" class="">Should ‘console’ be changed to ‘text’, because it doesn’t show in the console when you give an output <span class=""></span>directory?<span class="Apple-converted-space"> </span></span></p><div class=""><br class=""></div></div></blockquote>Yeah, I think it could. I’ve cc’d Justin for his input — he originally suggested Console.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">4) Could you please use an<span class="Apple-converted-space"> </span></span><span style="font-size: 10pt;" class="">html charset that supports UTF-8?</span></p><div class=""><br class=""></div></div></div></blockquote>Yep. Thanks for catching that!<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">5) The HTML report can look quite different to the source file if it includes tabs. Could you specify a smaller tab-size in the CSS file?</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div></div></div></blockquote><div>That’s a good question, and I don’t quite know the correct answer to it. GitHub has a complicated set of rules for tab sizing that makes a ‘best guess’ based on the source file type. I wonder if it’s a good candidate for a command line switch?</div><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">In the future (not for this patch):<span class="Apple-converted-space"> </span></span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">6) Could we support a user CSS file?<span class="Apple-converted-space"> </span></span></p><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Currently, the CSS rules are embedded into the html page. Could llvm-cov provide an option to use an external CSS file? This would give the user more flexibility.</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""><span class=""> </span></span><br class="webkit-block-placeholder"></div></div></div></blockquote>I agree that it’d give the user more flexibility, but it’d be difficult to do given the nature of the directory structure. Maybe, if you know you’re gonna be running it on a server where the ‘root’ is well-defined, we could just dump the css file to disk and put a relative <link> tag in. But if it’s gonna be ten directories down, we’ll need to have some logic in that replaces all the parent paths in the link with /../..’s to make the file resolve. I think it can be done, just with more input from the user about their intention with hosting.</div><div><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">7) Could we put the functions/lines summary information into the HTML files? As a rough example:<span class="Apple-converted-space"> </span></span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""><span class=""> <span class="Apple-converted-space"> </span></span></span><br class="webkit-block-placeholder"></div><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Lines: 9/10 (90%)</span></p><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Functions: 1/1 (100%)</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div></div></div></blockquote><div>I think this totally can be done — it’s out of scope for this patch (it’s already a pretty big patch as it is.)</div><div>Some kind of merging of ‘show’ and ‘report’ would be ideal. Maybe the index page has at-a-glance information about each file?</div><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Many thanks,</span></p><div style="margin-bottom: 0.0001pt; line-height: normal;" class=""><span style="font-size: 10pt;" class=""> </span><br class="webkit-block-placeholder"></div><p class="MsoNormal" style="margin-bottom: 0.0001pt; line-height: normal;"><span style="font-size: 10pt;" class="">Maggie</span></p></div></div></blockquote><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""><div class="gmail_quote">On Tue, Mar 8, 2016 at 12:56 AM, Harlan Haskins<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:hhaskins@apple.com" target="_blank" class="">hhaskins@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class="">I really need to get better at patches.<div class=""><br class=""></div><div class="">Updated patch without the build directory:</div><div class=""><br class=""></div><div class=""></div></div><br class=""><div style="word-wrap: break-word;" class=""><div class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 7, 2016, at 2:03 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div style="word-wrap: break-word;" class="">Thanks! I’m still working out how to properly tests the HTML generation (I need to build a compatible version of clang to make compatible profdata inputs.)<div class=""><br class=""></div><div class="">In the meantime, I think I’ve fixed the portability issues that you and Maggie suggested, as well as a preliminary index implementation and a better design.</div><div class=""><br class=""></div><div class="">Let me know what you think!</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Harlan</div><div class=""><br class=""></div><div class=""></div></div><span class=""><llvm-cov-html.diff></span><div style="word-wrap: break-word;" class=""><div class=""></div></div><span class=""><macro-coverage.zip></span><div style="word-wrap: break-word;" class=""><div class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 7, 2016, at 1:26 PM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" target="_blank" class="">xinliangli@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class=""><div class="">The patch looks pretty good now.</div><div class=""><br class=""></div><div class="">> std::string OutputPath = OutputDirectory;</div><div class="">> if (OutputPath != "") {</div><div class="">> sys::fs::create_directories(OutputDirectory);</div><div class="">> OutputPath += "/functions." + FileExt;</div><div class=""><br class=""></div><div class="">This is not portable. Try:</div><div class=""><br class=""></div><div class=""><div class=""> <span class="Apple-converted-space"> </span>llvm::sys::path::append(...) method</div></div><div class=""><br class=""></div><div class="">There are other places with similar code.</div><div class=""><br class=""></div><div class="">And it seems test cases are still missing?</div><div class=""><br class=""></div><div class="">thanks,</div><div class=""><br class=""></div><div class="">David</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Mar 4, 2016 at 10:46 AM, Harlan Haskins via llvm-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class="">Somehow the CSS include file didn’t make it into that diff.<div class=""></div></div><br class=""><div style="word-wrap: break-word;" class=""><div class=""></div><div class="">— Harlan</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 3, 2016, at 5:02 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div style="word-wrap: break-word;" class="">Hi all,<div class=""><br class=""></div><div class="">Thanks again for the reviews!</div><div class=""><br class=""></div><div class="">I’ve restructured how I handle subviews and pulled out the common behavior. I also addressed the issue with highlighting and showing macro expansions (and found a possible bug in clang because of it).</div><div class=""><br class=""></div><div class="">Attached is a) a new patch, and b) an HTML file showing a single line multi-macro expansion.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Harlan Haskins</div><div class=""><br class=""></div><div class=""></div></div><span class=""><macro.c.html></span><div style="word-wrap: break-word;" class=""><div class=""></div></div><span class=""><llvm-cov-html.diff></span><div style="word-wrap: break-word;" class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 2, 2016, at 3:00 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div style="word-wrap: break-word;" class="">Oh, I see! Yeah, this seems like something I overlooked. The HTML view currently just shows two expansions, one after the other.<div class=""><br class=""></div><div class="">I’ll revise the subview rendering with this in mind. Thanks for the simple example case!</div><div class=""><br class=""></div><div class="">Best,</div><div class="">Harlan</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 2, 2016, at 2:40 PM, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Wed, Mar 2, 2016 at 1:41 PM, Harlan Haskins<span class=""> </span><span dir="ltr" class=""><<a href="mailto:hhaskins@apple.com" target="_blank" class="">hhaskins@apple.com</a>></span><span class=""> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class="">Hi David,<div class=""><br class=""></div><div class="">Specifically with renderSubviews, in my refactor it seemed that their bodies were different enough (i.e. SourceCoverageViewConsole needs to track state between loop invocations to know whether or not to display a final view divider, and the common behavior is really just looping over the instantiation and expansion subviews. I can investigate converging them more, but I think it’s going to increase complexity.</div></div></blockquote><div class=""><br class=""></div><div class="">Emitting the final divider is easy to abstract away. The main difference I see is that in Console view, if there are multiple macro expansions in the same line, the line will be re-rendered again in order to highlight the macro. For instance given the following line with two macros,</div><div class=""> </div><div class=""> MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</div><div class=""><br class=""></div><div class="">The console dump will be two lines:</div><div class=""><br class=""></div><div class=""><font face="monospace, monospace" class="">1| 10| MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</font></div><div class=""><font face="monospace, monospace" class=""> ^^^^^^^^^^^</font></div><div class=""><font face="monospace, monospace" class=""> <span class="Apple-converted-space"> </span>.... expansion lines </font></div><div class=""><font face="monospace, monospace" class=""><br class=""></font></div><div class=""><font face="monospace, monospace" class=""> MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</font><span style="font-family: monospace;" class=""> ^^^^^^^^^^^^^</span></div><div class=""><font face="monospace, monospace" class=""> <span class="Apple-converted-space"> </span>.... expansion lines</font></div><div class=""><font face="monospace, monospace" class=""><br class=""></font></div><div class=""><font face="monospace, monospace" class=""><br class=""></font></div><div class="">Does HTML view lose that functionality? </div><div class=""><br class=""></div><div class="">Also the template instantiation subview rendering code looks sufficiently close between two classes.</div><div class=""><br class=""></div><div class="">thanks,</div><div class=""><br class=""></div><div class="">David</div><div class=""><br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><div class=""><br class=""></div><div class="">Also, I definitely need to add a test case.</div><div class=""><br class=""></div><div class="">Thanks!</div><span class=""><font color="#888888" class=""><div class="">Harlan</div></font></span><div class=""><div class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 2, 2016, at 10:43 AM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" target="_blank" class="">xinliangli@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Hi Harlan,<div class=""><br class=""></div><div class="">This looks great! Some high level comments. I find the code can be further restructured</div><div class="">1) high level methods can be commoned between two derived classes (and pushed to the base class) -- such as renderSubviews</div><div class="">2) the subclasses just need to provide virtual functions that implement the view specific low level routines.</div><div class=""><br class=""></div><div class="">Also there does not seem to be a test case.</div><div class=""><br class=""></div><div class="">thanks,</div><div class=""><br class=""></div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 1, 2016 at 6:03 PM, Harlan Haskins via llvm-commits<span class=""> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class=""> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class="">Oops, forgot to add a file to the patch.<div class=""><br class=""></div><div class="">New patch attached.</div><div class=""><br class=""></div><div class=""></div></div><br class=""><div style="word-wrap: break-word;" class=""><div class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 1, 2016, at 5:48 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div style="word-wrap: break-word;" class="">Hi all,<div class=""><br class=""></div><div class="">I’ve got a preliminary implementation of HTML generation for llvm-cov’s coverage reports.</div><div class=""><br class=""></div><div class="">The patch adds 2 flags to llvm-cov show:</div><div class=""><ul class=""><li class="">-format [html | console]</li><li class="">-output-dir <dirname></li></ul></div><div class=""><br class=""></div><div class="">Specifying -format=console will perform the current behavior (now the default), and -format=html will generate an HTML report.</div><div class="">If -output-dir is specified, then the output is split into one html or txt file per source file, named <source-name>.<ext>, with a directory structure that mimics the file system structure.</div><div class=""><br class=""></div><div class="">If neither are provided, the behavior remains the same.</div><div class=""><br class=""></div><div class="">I’m hoping to add an index with a browsable list of files within their directories, but for now I’ve attached the patch and a sample HTML file (In this case, AliasAnalysis.h, as included by swiftc).</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Harlan Haskins</div><div class=""><br class=""></div><div class=""></div></div><span class=""><AliasAnalysis.h.html></span><div style="word-wrap: break-word;" class=""><div class=""></div></div><span class=""><llvm-cov-html.diff></span><div style="word-wrap: break-word;" class=""></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""><br class=""></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class="">llvm-commits@lists.llvm.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""><br class=""></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div><br class=""></blockquote></div><br class=""><br clear="all" class=""><br class="">--<span class="Apple-converted-space"> </span><br class=""><div class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><font size="2" class=""><span style="font-family: arial, helvetica, sans-serif;" class="">Ying Yi</span><span style="font-family: arial, helvetica, sans-serif;" class=""><br class="">SN Systems Ltd - Sony Computer Entertainment Group.</span></font></div></div></div></div></div></div></div></div></blockquote></div><br class=""></body></html>