<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 8, 2016, at 10:55 AM, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Harlan Haskins <</span><a href="mailto:hhaskins@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">hhaskins@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> writes:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Thanks again! Responses inline.<br class=""><blockquote type="cite" class="">On Mar 8, 2016, at 5:08 AM, Ying Yi <<a href="mailto:maggieyi666@gmail.com" class="">maggieyi666@gmail.com</a>> wrote:<br class=""><br class="">Thanks for adding the index page. I have some comments:<br class=""><br class="">1) The ‘unistd.h’ header won’t build on windows.<br class=""><br class=""></blockquote>Thanks for catching that — I was using it to debug, but don’t need<br class="">it. I also don’t have a Windows machine to debug, so thank you for<br class="">investigating portability!<br class=""><br class=""><blockquote type="cite" class="">2) The help text for ‘-format’ is different from llvm-profdata.exe<br class="">tool, which uses the following style:<br class=""> -format=<html|console> - Format to output comparison ….<br class=""> Is there a standard way to do this?<br class=""><br class=""></blockquote>LLVM’s CommandLine library renders the help text. Also, I noticed I<br class="">used ‘comparison’ instead of ‘coverage’. Thanks!<br class=""><br class=""><blockquote type="cite" class="">3) Should ‘console’ be changed to ‘text’, because it doesn’t show in<br class="">the console when you give an output directory?<br class=""><br class=""></blockquote>Yeah, I think it could. I’ve cc’d Justin for his input — he originally<br class="">suggested Console.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">My only problem with "text" is that this includes ANSI escape sequences</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">when it uses colour, so text seems a bit misleading. That said, it</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">doesn't matter much - I'm fine with either.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class="">4) Could you please use an html charset that supports UTF-8?<br class=""><br class=""></blockquote>Yep. Thanks for catching that!<br class=""><br class=""><blockquote type="cite" class="">5) The HTML report can look quite different to the source file if it<br class="">includes tabs. Could you specify a smaller tab-size in the CSS file?<br class=""><br class=""></blockquote>That’s a good question, and I don’t quite know the correct answer to<br class="">it. GitHub has a complicated set of rules for tab sizing that makes a<br class="">‘best guess’ based on the source file type. I wonder if it’s a good<br class="">candidate for a command line switch?<br class=""><br class=""><blockquote type="cite" class="">In the future (not for this patch):<span class="Apple-converted-space"> </span><br class=""><br class="">6) Could we support a user CSS file?<span class="Apple-converted-space"> </span><br class="">Currently, the CSS rules are embedded into the html page. Could<br class="">llvm-cov provide an option to use an external CSS file? This would<br class="">give the user more flexibility.<br class=""><br class=""></blockquote>I agree that it’d give the user more flexibility, but it’d be<br class="">difficult to do given the nature of the directory structure. Maybe, if<br class="">you know you’re gonna be running it on a server where the ‘root’ is<br class="">well-defined, we could just dump the css file to disk and put a<br class="">relative <link> tag in. But if it’s gonna be ten directories down,<br class="">we’ll need to have some logic in that replaces all the parent paths in<br class="">the link with /../..’s to make the file resolve. I think it can be<br class="">done, just with more input from the user about their intention with<br class="">hosting.<br class=""><br class=""><blockquote type="cite" class="">7) Could we put the functions/lines summary information into the<br class="">HTML files? As a rough example:<br class=""><br class="">Lines: 9/10 (90%)<br class="">Functions: 1/1 (100%)<br class=""><br class=""></blockquote>I think this totally can be done — it’s out of scope for this patch<br class="">(it’s already a pretty big patch as it is.)<br class="">Some kind of merging of ‘show’ and ‘report’ would be ideal. Maybe the<br class="">index page has at-a-glance information about each file?<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Yep, this sounds like a great idea, but it's probably more suited to a</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">follow up patch.</span></div></blockquote></div><br class=""></div></div></body></html>