<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 1:31 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Mar 7, 2016 at 12:34 PM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">This isn't really the place to debate LLVM policy - the code owner asked you to revert a patch due to concerns over the review. Please revert it & take up the discussion about general policy on llvm-dev, or the discussion about whether the revert is merited after reverting. There's really no harm in reverting a patch.</div></blockquote><div><br></div></span><div>Agreed. No harm in reverting, so let's get that done. </div></div></div></div></blockquote><div><br></div><div>Not debating whether this is harmful or not, 'reverting' needs a good reason -- not based on false statement the patch is not properly reviewed, which is clearly is not the case.</div><div><br></div><div>thanks,</div><div><br></div><div>David</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>That being said, I think that Chandler dropped the ball here. This patch has been on Phab for a month and a half. I would have expected Chandler to chime in with at least an ETA for when he would get a chance to look at it, given the importance of this patch.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Mon, Mar 7, 2016 at 10:17 AM, Xinliang David Li via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Mar 7, 2016 at 9:58 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div dir="ltr">On Mon, Mar 7, 2016 at 6:47 PM Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 7, 2016 at 1:40 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">chandlerc added a comment.<br>
<span><br>
In <a href="http://reviews.llvm.org/D16381#367348" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16381#367348</a>, @davidxl wrote:<br>
<br>
> LGTM.<br>
><br>
> This looks really great, so let's move on with this long waited missing feature.<br>
<br>
<br>
</span>David, this is not an area of LLVM you have done substantial work on, and this is a very significant feature.<br></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>The patch has been reviewed and tested thoroughly. The approach used by the patch has been discussed many times in the past since last October in various contexts in which you were involved. </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
I'm sorry that I have not had time to review this yet, but the correct response is not for you to make a patch as LGTM.</blockquote><div><br></div><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Again we have done extensive review on this patch. According to your standard, it looks like only you can approve patches in the inliner?</div></div></div></div></blockquote><div><br></div></span><div>Nope, but the only people on this thread are you and Easwaran.</div><div><br></div></div></div></blockquote><div><br></div></span><div>There are 4 reviewers listed (including you) and 7 subscribers including llvm-commits. Click on 'Show older changes' to see the review history. So what exactly do you mean the only people on the thread are me and Easwaran? </div><span><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div>There are other folks who I think could reasonable review changes to the inliner, but you've not gotten a review from any of them... Hal, Philip, Sanjoy, or several others would all potentially be reasonable people.</div></div></div></blockquote><div><br></div><div><br></div></span><div>You and Hal are listed as reviewers, and the patch were pinged several times.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> IMO this is not healthy to the project and more people need to get involved. As it stands today, it seems to be very hard to everybody in the community to make any changes in the inliner due to this. </div></div></div></div></blockquote><div><br></div></span><div>Note that it is very hard to make changes to the inliner in general. It isn't clear that a small number of reviewers for inliner changes is a substantial issue for the community in general.</div><span><div> </div></span></div></div></blockquote><div><br></div></span><div>Why do you think it is hard to make changes to inliner? As far as I know, this feature is a *long* waited feature by the community. People who care have been following. This patch is a great progress forward for the project not the other way around. If you see substantial issue, please be specific.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> Please revert this and let's actually get it reviewed before it goes into the project.<br>
<div><div><br></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Actually get reviewed? What do you mean? Have you really followed the thread? If you want to be constructive, please do your part of the review, but not request a revert like this.</div></div></div></div></blockquote><div><br></div></span><div>The patch needs to be reviewed by someone who has significant experience working on LLVM's inliner, as it is a significant change. </div></div></div></blockquote><div><br></div><div><br></div></span><div>The patch is very nicely structured and it is not a significant change. We have been very careful in designing and testing. Besides both Easwaran and I have extensive experience in inliner design in general. </div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>The patch shouldn't stay in the tree just because the review is slow, as that doesn't actually solve anything. Everyone else is working with reviewers to get their patches reviewed, and I don't think it is reasonable for you to just push forward. =/</div></div></div></blockquote><div><br></div></span><div>Let me repeat, the patch has been carefully reviewed. I am not saying that all problems have been covered, but it is in reasonably good shape before it is approved. We are not rushing it in -- the related discussion has been going on for half a year! </div><div><br></div><div>Only more tests from the community can help reveal more problems -- if there are problems, we can always fix them. Have you seen actual problem to the community by this patch?</div><span><font color="#888888"><div><br></div><div>David</div><div><br></div><div> </div></font></span></div><br></div></div>
<br></div></div><span>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></span></blockquote></div><br></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>