<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 11:09 AM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Mon, Mar 7, 2016 at 7:36 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">This is a nice change in general, but why convert from<br>
GlobalValue::DefaultVisibility to default? We had a fully covered<br>
switch before.<br></blockquote><div><br></div></span><div>That's what I was not sure, so I was thinking that that could cause a "function does not return a value" warning. I will revert that part.</div></div></div></div></blockquote><div><br></div><div>We have guidance about that here: <a href="http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations">http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a></div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
<br>
<br>
On 6 March 2016 at 19:54, Rui Ueyama via llvm-commits<br>
<div><div><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: ruiu<br>
> Date: Sun Mar 6 18:54:17 2016<br>
> New Revision: 262813<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262813&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262813&view=rev</a><br>
> Log:<br>
> Split BitcodeFile::parse. NFC.<br>
><br>
> Modified:<br>
> lld/trunk/ELF/InputFiles.cpp<br>
><br>
> Modified: lld/trunk/ELF/InputFiles.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=262813&r1=262812&r2=262813&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=262813&r1=262812&r2=262813&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/ELF/InputFiles.cpp (original)<br>
> +++ lld/trunk/ELF/InputFiles.cpp Sun Mar 6 18:54:17 2016<br>
> @@ -414,6 +414,17 @@ bool BitcodeFile::classof(const InputFil<br>
> return F->kind() == BitcodeKind;<br>
> }<br>
><br>
> +static uint8_t getGvVisibility(const GlobalValue *GV) {<br>
> + switch (GV->getVisibility()) {<br>
> + case GlobalValue::HiddenVisibility:<br>
> + return STV_HIDDEN;<br>
> + case GlobalValue::ProtectedVisibility:<br>
> + return STV_PROTECTED;<br>
> + default:<br>
> + return STV_DEFAULT;<br>
> + }<br>
> +}<br>
> +<br>
> void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {<br>
> LLVMContext Context;<br>
> std::unique_ptr<IRObjectFile> Obj = check(IRObjectFile::create(MB, Context));<br>
> @@ -432,23 +443,14 @@ void BitcodeFile::parse(DenseSet<StringR<br>
> if (const Comdat *C = GV->getComdat())<br>
> if (!KeptComdats.count(C))<br>
> continue;<br>
> - switch (GV->getVisibility()) {<br>
> - case GlobalValue::DefaultVisibility:<br>
> - Visibility = STV_DEFAULT;<br>
> - break;<br>
> - case GlobalValue::HiddenVisibility:<br>
> - Visibility = STV_HIDDEN;<br>
> - break;<br>
> - case GlobalValue::ProtectedVisibility:<br>
> - Visibility = STV_PROTECTED;<br>
> - break;<br>
> - }<br>
> + Visibility = getGvVisibility(GV);<br>
> }<br>
><br>
> SmallString<64> Name;<br>
> raw_svector_ostream OS(Name);<br>
> Sym.printName(OS);<br>
> StringRef NameRef = Saver.save(StringRef(Name));<br>
> +<br>
> SymbolBody *Body;<br>
> uint32_t Flags = Sym.getFlags();<br>
> bool IsWeak = Flags & BasicSymbolRef::SF_Weak;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>