<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 11:11 AM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:me@filcab.net" target="_blank">me@filcab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">How is the header self-contained and the function declared is you don't include the other header, then?</blockquote><div><br></div><div>Ok -- good point.</div><div><br></div><div>David </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br></div><div>Thank you,</div><div><br></div><div>  Filipe<div><div class="h5"><span></span><br><br>On Monday, 7 March 2016, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 5:42 AM, Filipe Cabecinhas via llvm-commits <span dir="ltr"><<a>llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Mon Mar  7 07:42:17 2016<br>
New Revision: 262827<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262827&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262827&view=rev</a><br>
Log:<br>
[Fix r262785] Fix missing declaration when COMPILER_RT_BOOL_CMPXCHG was used but InstrProfilingUtil.h wasn't included.<br>
<br>
Also fixed declaration which still had the pre-r262788 name.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/profile/InstrProfilingPort.h<br>
    compiler-rt/trunk/lib/profile/InstrProfilingUtil.h<br>
<br>
Modified: compiler-rt/trunk/lib/profile/InstrProfilingPort.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfilingPort.h?rev=262827&r1=262826&r2=262827&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfilingPort.h?rev=262827&r1=262826&r2=262827&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/profile/InstrProfilingPort.h (original)<br>
+++ compiler-rt/trunk/lib/profile/InstrProfilingPort.h Mon Mar  7 07:42:17 2016<br>
@@ -52,6 +52,7 @@<br>
   __sync_bool_compare_and_swap(Ptr, OldV, NewV)<br>
 #endif<br>
 #else /* COMPILER_RT_HAS_ATOMICS != 1 */<br>
+#include "InstrProfilingUtil.h"<br></blockquote><div><br></div><div>This include is not needed -- perhaps change it to a comment.</div><div><br></div><div>David</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 #define COMPILER_RT_BOOL_CMPXCHG(Ptr, OldV, NewV)                              \<br>
   lprofBoolCmpXchg((void **)Ptr, OldV, NewV)<br>
 #endif<br>
<br>
Modified: compiler-rt/trunk/lib/profile/InstrProfilingUtil.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfilingUtil.h?rev=262827&r1=262826&r2=262827&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/profile/InstrProfilingUtil.h?rev=262827&r1=262826&r2=262827&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/profile/InstrProfilingUtil.h (original)<br>
+++ compiler-rt/trunk/lib/profile/InstrProfilingUtil.h Mon Mar  7 07:42:17 2016<br>
@@ -22,6 +22,6 @@ static inline char *getenv(const char *n<br>
<br>
 int lprofGetHostName(char *Name, int Len);<br>
<br>
-unsigned BoolCmpXchg(void **Ptr, void *OldV, void *NewV);<br>
+unsigned lprofBoolCmpXchg(void **Ptr, void *OldV, void *NewV);<br>
<br>
 #endif  /* PROFILE_INSTRPROFILINGUTIL_H */<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a>llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>
</blockquote></div></div></div>
</blockquote></div><br></div></div>