<div dir="ltr">
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%">Hi Harlan,</span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%">The patch is really useful. It will
help our test team migrate from gcov to llvmcov. Thanks for working on this.</span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%">Currently, the patch does not build
and run on Windows. I have some comments regarding this:</span></p>
<p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt"><br></span></p><p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt">1) I got
this build error when using Visual Studio 2013: <span style="mso-spacerun:yes"> </span></span></p>
<p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt"> </span></p>
<p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt;color:rgb(30,30,30);background:white none repeat scroll 0% 0%">14>I:\git\llvm\tools\llvm-cov\CodeCoverage.cpp(114):
error C2668: 'llvm::make_unique' : ambiguous call to overloaded function</span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:rgb(30,30,30);background:white none repeat scroll 0% 0%">14><span style="mso-spacerun:yes">
</span>I:\git\llvm\include\llvm/ADT/STLExtras.h(404): could be
'std::unique_ptr<llvm::raw_fd_ostream,std::default_delete<llvm::raw_fd_ostream>></span><span style="font-size:10pt;line-height:115%;color:rgb(30,30,30)"></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:rgb(30,30,30)"><br></span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:rgb(30,30,30)">Would changing <span style="background:white none repeat scroll 0% 0%">'make_unique'</span> to <span style="background:white none repeat scroll 0% 0%">'llvm::make_unique'</span> resolve
this problem?</span><span style="font-size:10pt;line-height:115%"></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br></span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%">2) <span style="mso-spacerun:yes"> </span>When ‘–output-dir’ option is specified, the
html report per source file needs to consider Windows path construction:</span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br></span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%">a) In line 504 of CodeCoverage.cpp
file, the <span style="color:rgb(30,30,30);background:white none repeat scroll 0% 0%">'</span>Basename<span style="color:rgb(30,30,30);background:white none repeat scroll 0% 0%">'</span> and <span style="color:rgb(30,30,30);background:white none repeat scroll 0% 0%">'</span>SourceFile<span style="color:rgb(30,30,30);background:white none repeat scroll 0% 0%">'</span> need to
remove the drive letter (e.g. C: )</span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%">b) In line 508 of CodeCoverage.cpp
file, the <span style="color:rgb(30,30,30);background:white none repeat scroll 0% 0%">'</span><span style="color:rgb(30,30,30)">OutputPath<span style="background:white none repeat scroll 0% 0%">'</span> uses <span style="background:white none repeat scroll 0% 0%">'</span>\\<span style="background:white none repeat scroll 0% 0%">'</span> on Windows instead of <span style="background:white none repeat scroll 0% 0%">'</span>/<span style="background:white none repeat scroll 0% 0%">'</span> (on Linux)</span></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br></span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%">Also, are you currently working on adding
an index with a list of files with clickable links?</span></p>
<p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt"><br></span></p><p class="MsoNormal" style="margin-bottom:0.0001pt;line-height:normal"><span style="font-size:10pt">Thanks</span><span style="font-size:10pt"></span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><br>
Maggie</span></p>
<div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 4, 2016 at 6:46 PM, Harlan Haskins via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Somehow the CSS include file didn’t make it into that diff.<div></div></div><br><div style="word-wrap:break-word"><div></div><div>— Harlan</div><div><br><div><blockquote type="cite"><div>On Mar 3, 2016, at 5:02 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div style="word-wrap:break-word">Hi all,<div><br></div><div>Thanks again for the reviews!</div><div><br></div><div>I’ve restructured how I handle subviews and pulled out the common behavior. I also addressed the issue with highlighting and showing macro expansions (and found a possible bug in clang because of it).</div><div><br></div><div>Attached is a) a new patch, and b) an HTML file showing a single line multi-macro expansion.</div><div><br></div><div>Thanks,</div><div>Harlan Haskins</div><div><br></div><div></div></div><span><macro.c.html></span><div style="word-wrap:break-word"><div></div></div><span><llvm-cov-html.diff></span><div style="word-wrap:break-word"><div><br><div><blockquote type="cite"><div>On Mar 2, 2016, at 3:00 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div style="word-wrap:break-word">Oh, I see! Yeah, this seems like something I overlooked. The HTML view currently just shows two expansions, one after the other.<div><br></div><div>I’ll revise the subview rendering with this in mind. Thanks for the simple example case!</div><div><br></div><div>Best,</div><div>Harlan</div><div><br><div><blockquote type="cite"><div>On Mar 2, 2016, at 2:40 PM, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 2, 2016 at 1:41 PM, Harlan Haskins<span> </span><span dir="ltr"><<a href="mailto:hhaskins@apple.com" target="_blank">hhaskins@apple.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">Hi David,<div><br></div><div>Specifically with renderSubviews, in my refactor it seemed that their bodies were different enough (i.e. SourceCoverageViewConsole needs to track state between loop invocations to know whether or not to display a final view divider, and the common behavior is really just looping over the instantiation and expansion subviews. I can investigate converging them more, but I think it’s going to increase complexity.</div></div></blockquote><div><br></div><div>Emitting the final divider is easy to abstract away. The main difference I see is that in Console view, if there are multiple macro expansions in the same line, the line will be re-rendered again in order to highlight the macro. For instance given the following line with two macros,</div><div> </div><div> MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</div><div><br></div><div>The console dump will be two lines:</div><div><br></div><div><font face="monospace, monospace">1| 10| MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</font></div><div><font face="monospace, monospace"> ^^^^^^^^^^^</font></div><div><font face="monospace, monospace"> .... expansion lines </font></div><div><font face="monospace, monospace"><br></font></div><div><font face="monospace, monospace"> MY_MACRO(10, 10); MY_MACRO(20,10); // line 10</font><span style="font-family:monospace"> ^^^^^^^^^^^^^</span></div><div><font face="monospace, monospace"> .... expansion lines</font></div><div><font face="monospace, monospace"><br></font></div><div><font face="monospace, monospace"><br></font></div><div>Does HTML view lose that functionality? </div><div><br></div><div>Also the template instantiation subview rendering code looks sufficiently close between two classes.</div><div><br></div><div>thanks,</div><div><br></div><div>David</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>Also, I definitely need to add a test case.</div><div><br></div><div>Thanks!</div><span><font color="#888888"><div>Harlan</div></font></span><div><div><div><br><div><blockquote type="cite"><div>On Mar 2, 2016, at 10:43 AM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Hi Harlan,<div><br></div><div>This looks great! Some high level comments. I find the code can be further restructured</div><div>1) high level methods can be commoned between two derived classes (and pushed to the base class) -- such as renderSubviews</div><div>2) the subclasses just need to provide virtual functions that implement the view specific low level routines.</div><div><br></div><div>Also there does not seem to be a test case.</div><div><br></div><div>thanks,</div><div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 1, 2016 at 6:03 PM, Harlan Haskins via llvm-commits<span> </span><span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">Oops, forgot to add a file to the patch.<div><br></div><div>New patch attached.</div><div><br></div><div></div></div><br><div style="word-wrap:break-word"><div></div><div><br></div><div><br><div><blockquote type="cite"><div>On Mar 1, 2016, at 5:48 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div style="word-wrap:break-word">Hi all,<div><br></div><div>I’ve got a preliminary implementation of HTML generation for llvm-cov’s coverage reports.</div><div><br></div><div>The patch adds 2 flags to llvm-cov show:</div><div><ul><li>-format [html | console]</li><li>-output-dir <dirname></li></ul></div><div><br></div><div>Specifying -format=console will perform the current behavior (now the default), and -format=html will generate an HTML report.</div><div>If -output-dir is specified, then the output is split into one html or txt file per source file, named <source-name>.<ext>, with a directory structure that mimics the file system structure.</div><div><br></div><div>If neither are provided, the behavior remains the same.</div><div><br></div><div>I’m hoping to add an index with a browsable list of files within their directories, but for now I’ve attached the patch and a sample HTML file (In this case, AliasAnalysis.h, as included by swiftc).</div><div><br></div><div>Thanks,</div><div>Harlan Haskins</div><div><br></div><div></div></div><span><AliasAnalysis.h.html></span><div style="word-wrap:break-word"><div></div></div><span><llvm-cov-html.diff></span><div style="word-wrap:break-word"></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br><br></blockquote></div><br></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:llvm-commits@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">llvm-commits@lists.llvm.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2"><span style="font-family:arial,helvetica,sans-serif">Ying Yi</span><span style="font-family:arial,helvetica,sans-serif"><br>SN Systems Ltd - Sony Computer Entertainment Group.</span><span style="font-family:arial,helvetica,sans-serif"></span></font><br></div></div></div></div></div></div>
</div></div>