<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi David,<div class=""><br class=""></div><div class="">Specifically with renderSubviews, in my refactor it seemed that their bodies were different enough (i.e. SourceCoverageViewConsole needs to track state between loop invocations to know whether or not to display a final view divider, and the common behavior is really just looping over the instantiation and expansion subviews. I can investigate converging them more, but I think it’s going to increase complexity.</div><div class=""><br class=""></div><div class="">Also, I definitely need to add a test case.</div><div class=""><br class=""></div><div class="">Thanks!</div><div class="">Harlan</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 2, 2016, at 10:43 AM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" class="">xinliangli@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Harlan,<div class=""><br class=""></div><div class="">This looks great! Some high level comments. I find the code can be further restructured</div><div class="">1) high level methods can be commoned between two derived classes (and pushed to the base class) -- such as renderSubviews</div><div class="">2) the subclasses just need to provide virtual functions that implement the view specific low level routines.</div><div class=""><br class=""></div><div class="">Also there does not seem to be a test case.</div><div class=""><br class=""></div><div class="">thanks,</div><div class=""><br class=""></div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 1, 2016 at 6:03 PM, Harlan Haskins via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Oops, forgot to add a file to the patch.<div class=""><br class=""></div><div class="">New patch attached.</div><div class=""><br class=""></div><div class=""></div></div><br class=""><div style="word-wrap:break-word" class=""><div class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 1, 2016, at 5:48 PM, Harlan Haskins via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div style="word-wrap:break-word" class="">Hi all,<div class=""><br class=""></div><div class="">I’ve got a preliminary implementation of HTML generation for llvm-cov’s coverage reports.</div><div class=""><br class=""></div><div class="">The patch adds 2 flags to llvm-cov show:</div><div class=""><ul class=""><li class="">-format [html | console]</li><li class="">-output-dir <dirname></li></ul></div><div class=""><br class=""></div><div class="">Specifying -format=console will perform the current behavior (now the default), and -format=html will generate an HTML report.</div><div class="">If -output-dir is specified, then the output is split into one html or txt file per source file, named <source-name>.<ext>, with a directory structure that mimics the file system structure.</div><div class=""><br class=""></div><div class="">If neither are provided, the behavior remains the same.</div><div class=""><br class=""></div><div class="">I’m hoping to add an index with a browsable list of files within their directories, but for now I’ve attached the patch and a sample HTML file (In this case, AliasAnalysis.h, as included by swiftc).</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Harlan Haskins</div><div class=""><br class=""></div><div class=""></div></div><span class=""><AliasAnalysis.h.html></span><div style="word-wrap:break-word" class=""><div class=""></div></div><span class=""><llvm-cov-html.diff></span><div style="word-wrap:break-word" class=""></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div><br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>