<div dir="ltr">Ok, removed in r262346. Thanks for clarification and sorry for breakage.<br><div><br></div><div>Nikolay</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-03-01 19:02 GMT+03:00 Christian König <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>It would still be better to remove
those lines now and add them back when they are used.<br>
<br>
This way you don't accidentally leave dead code in here when the
patch who makes use of it never lands.<br>
<br>
Christian.<div><div class="h5"><br>
<br>
Am 01.03.2016 um 16:56 schrieb Haustov, Nikolay via llvm-commits:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">The warning was about unused static function.
Valery has pending changes that will use these decoders, so
they will get used soon.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">Nikolay<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US"> David Blaikie [<a href="mailto:dblaikie@gmail.com" target="_blank">mailto:dblaikie@gmail.com</a>]
<br>
<b>Sent:</b> Tuesday, March 1, 2016 6:51 PM<br>
<b>To:</b> Haustov, Nikolay<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r262338 - [AMDGPU] Fix build
warnings.<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p>What was the warning? And is there a reason we want to leave
those lines in the file, though commented out (generally we
just delete dead code)<u></u><u></u></p>
<div>
<p class="MsoNormal">On Mar 1, 2016 6:55 AM, "Nikolay Haustov
via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>
wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: nhaustov<br>
Date: Tue Mar 1 08:50:59 2016<br>
New Revision: 262338<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262338&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=262338&view=rev</a><br>
Log:<br>
[AMDGPU] Fix build warnings.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp<br>
<br>
Modified:
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp?rev=262338&r1=262337&r2=262338&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp?rev=262338&r1=262337&r2=262338&view=diff</a><br>
==============================================================================<br>
---
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
(original)<br>
+++
llvm/trunk/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
Tue Mar 1 08:50:59 2016<br>
@@ -66,12 +66,12 @@ DECODE_OPERAND(VReg_64)<br>
DECODE_OPERAND(VReg_96)<br>
DECODE_OPERAND(VReg_128)<br>
<br>
-DECODE_OPERAND(SGPR_32)<br>
+//DECODE_OPERAND(SGPR_32)<br>
DECODE_OPERAND(SReg_32)<br>
DECODE_OPERAND(SReg_64)<br>
DECODE_OPERAND(SReg_128)<br>
DECODE_OPERAND(SReg_256)<br>
-DECODE_OPERAND(SReg_512)<br>
+//DECODE_OPERAND(SReg_512)<br>
<br>
#define GET_SUBTARGETINFO_ENUM<br>
#include "AMDGPUGenSubtargetInfo.inc"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
llvm-commits mailing list
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>